netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Herbert <therbert@google.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
	Andi Kleen <andi@firstfloor.org>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] Software receive packet steering
Date: Tue, 21 Apr 2009 11:52:07 -0700	[thread overview]
Message-ID: <65634d660904211152l6c17aa6dpf7e626474acfe499@mail.gmail.com> (raw)
In-Reply-To: <20090421084636.198b181e@nehalam>

>> Hello Tom
>>
>> I was thinking about your patch (and David's one), and thought it could be
>> possible to spread packets to other cpus only if current one is under stress.
>>
>> A posssible metric would be to test if softirq is handled by ksoftirqd
>> (stress situation) or not.
>>
>> Under moderate load, we could have one active cpu (and fewer cache line
>> transferts), keeping good latencies.
>>
>> I tried alternative approach to solve the Multicast problem raised some time ago,
>> but still have one cpu handling one device. Only wakeups were defered to a
>> workqueue (and possibly another cpu) if running from ksoftirq only.
>> Patch not yet ready for review, but based on a previous patch that was more
>> intrusive (touching kernel/softirq.c)
>>
>> Under stress, your idea permits to use more cpus for a fast NIC and get better
>> throughput. Its more generic.
>
> I would like to see some way to have multiple CPU's pulling packets and adapting
> the number of CPU's being used based on load. Basically, turn all device is into
> receive multiqueue. The mapping could be adjusted by user level (see irqbalancer).
>

That is possible and don't think the design of our patch would
preclude it, but I am worried that each time the mapping from a
connection to a CPU changes this could cause of out of order packets.
I suppose this is similar problem to changing the RSS hash mappings in
a device.

Tom

  reply	other threads:[~2009-04-21 18:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 22:48 [PATCH] Software receive packet steering Tom Herbert
2009-04-08 23:08 ` Stephen Hemminger
2009-04-08 23:09 ` Stephen Hemminger
2009-04-08 23:15   ` David Miller
2009-04-09 16:43     ` Tom Herbert
2009-04-09 18:23       ` Ben Hutchings
2009-04-09 21:17       ` David Miller
2009-04-09  0:36 ` David Miller
2009-04-09  4:40   ` Tom Herbert
2009-04-09  5:24     ` David Miller
2009-04-20 10:32 ` Andi Kleen
2009-04-20 10:46   ` David Miller
2009-04-21  3:26   ` Tom Herbert
2009-04-21  9:48     ` Eric Dumazet
2009-04-21 15:46       ` Stephen Hemminger
2009-04-21 18:52         ` Tom Herbert [this message]
2009-04-22  9:21           ` David Miller
2009-04-22 15:46             ` Tom Herbert
2009-04-22 18:49             ` Rick Jones
2009-04-22 20:44             ` Jesper Dangaard Brouer
2009-04-23  6:58               ` Jens Axboe
2009-04-23  7:25                 ` David Miller
2009-04-23  7:29                   ` Jens Axboe
2009-04-23  9:12               ` Jens Laas
2009-04-22 14:33         ` Martin Josefsson
2009-04-23  7:34           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65634d660904211152l6c17aa6dpf7e626474acfe499@mail.gmail.com \
    --to=therbert@google.com \
    --cc=andi@firstfloor.org \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).