From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org
Cc: "The UK's National Cyber Security Centre (NCSC)"
<security@ncsc.gov.uk>, stable <stable@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net] net/packet: move reference count in packet_sock to 64 bits
Date: Thu, 30 Nov 2023 10:15:58 -0500 [thread overview]
Message-ID: <6568a72eab745_f2ed0294ad@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <37d84da7-12d2-7646-d4fb-240d1023fe7a@iogearbox.net>
Daniel Borkmann wrote:
> On 11/30/23 3:20 PM, Greg Kroah-Hartman wrote:
> > In some potential instances the reference count on struct packet_sock
> > could be saturated and cause overflows which gets the kernel a bit
> > confused. To prevent this, move to a 64bit atomic reference count to
> > prevent the possibility of this type of overflow.
> >
> > Because we can not handle saturation, using refcount_t is not possible
> > in this place. Maybe someday in the future if it changes could it be
> > used.
> >
> > Original version from Daniel after I did it wrong, I've provided a
> > changelog.
> >
> > Reported-by: "The UK's National Cyber Security Centre (NCSC)" <security@ncsc.gov.uk>
> > Cc: stable <stable@kernel.org>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks!
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2023-11-30 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:20 [PATCH net] net/packet: move reference count in packet_sock to 64 bits Greg Kroah-Hartman
2023-11-30 14:36 ` Daniel Borkmann
2023-11-30 15:15 ` Willem de Bruijn [this message]
2023-12-01 9:19 ` Daniel Borkmann
2023-12-01 9:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6568a72eab745_f2ed0294ad@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=security@ncsc.gov.uk \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).