From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB351BC47; Tue, 16 Jan 2024 13:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arinc9.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arinc9.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arinc9.com header.i=@arinc9.com header.b="D1yNi7bo" Received: by mail.gandi.net (Postfix) with ESMTPSA id F1C9760007; Tue, 16 Jan 2024 13:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1705411903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GGfIWOZzoS5FI6VacxBhh6eflIWOIAfi24KVKKdHfY=; b=D1yNi7boiHKa08RmzfZ6e2rsRmm1OFbabWijcNnT6H2ifQWwEn128b8yg4R7A8gA5WJpjE DH8SgTCStZCT55yl2OIvuYFAzknW1ULVe2+Q91EpFHI8HUhx+ixb+2W/AuY+fI+sdTlSdS WU4MWcG//90J9h9sA6a+x6qTkDuByO2rldOp7ilHMedD6Wo+EiWg5QczidTE3SeXJmwOFv sEyJX6s8hd5sv+sOnng9NNXHn/5mJ5pU+f9P2O0N+SY9Vq0JDHkc+fFy/ehzs9B4Y/Ji5J +6hM5dD0FmABHXb/voX6CWeOTK8kTgnIc4INpgmiNnaPKpO1sIVUD7yyfsbsUw== Message-ID: <656cf9e2-2ab9-48ea-9eea-7599f14f3a41@arinc9.com> Date: Tue, 16 Jan 2024 16:31:34 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH net-next 7/8] net: dsa: mt7530: correct port capabilities of MT7988 Content-Language: en-US To: Daniel Golle , Vladimir Oltean Cc: Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Luiz Angelo Daros de Luca , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240113102529.80371-1-arinc.unal@arinc9.com> <20240113102529.80371-8-arinc.unal@arinc9.com> <20240115214238.bnlvomatududng6l@skbuf> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com On 16.01.2024 01:09, Daniel Golle wrote: > On Mon, Jan 15, 2024 at 11:42:38PM +0200, Vladimir Oltean wrote: >> On Sat, Jan 13, 2024 at 01:25:28PM +0300, Arınç ÜNAL wrote: >>> On the switch on the MT7988 SoC, there are only 4 PHYs. That's port 0 to 3. >>> Set the internal phy cases to '0 ... 3'. >>> >>> Signed-off-by: Arınç ÜNAL >>> Acked-by: Daniel Golle >>> --- >> >> For this patch to be obviously correct, please make a statement in the >> commit message about port 4. It doesn't exist at all? > > Correct. As shown in Block Diagram 8.1.1.3 on page 125 of > MT7988A Wi-Fi 7 Generation Router Platform: Datasheet (Open Version) > Version: 0.1 > Release Date: 2023-10-18 > which is available publicly on BananaPi's Wiki[1]. > > Port 0~3 are TP user ports, Port 6 is internally linked to XGMII of MAC 0. > Port 4 and 5 are not used at all in this design. > > [1]: https://wiki.banana-pi.org/Banana_Pi_BPI-R4#Documents Thanks for chiming in Daniel, I will include this on the patch log. Arınç