From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9394194C62; Mon, 21 Oct 2024 13:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729517258; cv=none; b=XHdNsCvJDCtK1qsEyfhDGk6CeqbU/qy15F3nfo/LHkjG+CLSspIgYKE6q4dfWj8+eXeerrvJZDTyArky0/MAgqu87n5fklnV31if+aFY4RhFWFihfbBaKESnohe6xRg4lXstu8suyhmNdup8NkTfDq35xC+I7m4Wqz7Ubv8UkJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729517258; c=relaxed/simple; bh=tpUMAOXEdQHMV/LTUs7UVRMGe8vwcmFVR8ILTP6wDLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rgjJ39/SPbkfxoEEvKp6Outra8aYaTb1aAwpvSTeMYDJWof2Jp1oiveCJ5pMiN6RPvrC5GROseioX1Eruql29KmaFoGMFv+g6EN9HWsyZ/GxzsdqqarXm0oJSNhdAbWZD5mlqRwlLy5DuQJX7v5zd7cWG9VN01rxje78dOro05M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Vf7B2c8q; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Vf7B2c8q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=oyGvjz3/Hib5fIbnXMnThAnbAp+YfY0g/qjJuNmpK4E=; b=Vf7B2c8qiEwkPVEwyBcYyfO60W ioO34B4XYd++tnetkNAqExZEqPVXB5v/j6vULA/sT4YpCzZMazXIqcCo/A8XKYr0pvhjeRmAujCHP uEQiS7X6XEbId/OSkwXV1uow9Eku1mO7mWIrIf174yXI9Lp4onWcoSU3gm4sfrnNbrLA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1t2sRK-00Aj01-4D; Mon, 21 Oct 2024 15:27:18 +0200 Date: Mon, 21 Oct 2024 15:27:18 +0200 From: Andrew Lunn To: Inochi Amaoto Cc: Chen Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Inochi Amaoto , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Giuseppe Cavallaro , Yixun Lan , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC Message-ID: <65720a16-d165-4379-a01f-54340fb907df@lunn.ch> References: <20241021103617.653386-1-inochiama@gmail.com> <20241021103617.653386-5-inochiama@gmail.com> <227daa87-1924-4b0b-80db-77507fc20f19@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > It is related to the RGMII delay. On sg2044, when the phy > sets rx-delay, the interal mac is not set the same delay, > so this is needed to be set. This is the wrong way to do it. Please look at how phy-mode should be used, the four different "rgmii" values. Nearly everybody gets this wrong, so there are plenty of emails from me in the netdev list about how it should be done. Andrew --- pw-bot: cr