From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE342E3B15; Mon, 11 May 2026 20:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778530726; cv=none; b=R3zzLiV74NEr3xrEtrFXl3cp2QER601dZ/0cZaXczU5OUNn/pNA3KwYlxghGIPP8p1wmhsIJCPo/Gvft36ubHfUvd5RmrfuLL0VuWASaF81q5tR9WYDjowS278q2MIaSgq1X7jOzmSdkpR9Iyd/rNNXYpsw9EP9I0Xzc0kd/bgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778530726; c=relaxed/simple; bh=0VjGp+tXbz9uFrh/GLx9A0gDKs6zfM8IUPWa4rbivE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GhdJWw6ajz8XkCxtj1RYvA+Mr66H2tF9zyqMhrNy2sbiFDZytjnoGzOL4NTQkxL6JaA8CTJGav8fPoe0P7zK+M3Ez1LevVhQmzqnbRUTrUdryid8RGmLmi4UnJqTGCRqAx76EyC7TDvxPOvMHE9/a33wJ90Sb/3bjIb0fzzCcsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=NNdRg8IA; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NNdRg8IA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mtQa3BI1a6Wl1vb+E1fQiei8z4Ufqvm312kxxeSce2M=; b=NNdRg8IAe+w77wDtdltpkGJUCl G/yp/TSl2Ey1sQDaf5qCEi9XoYst15iVA74KyRN7Mjo4/S2h01vhFEH2VvjDB1ZrzCyRhLTVGvyX4 cEfBzFouz+X2fr8Sq6vIDsGjv/N77ZY2m9GuHQ+hrTVhA0AunDqfDUrLhPs+WOkGFuok=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wMX5G-002R0L-Lc; Mon, 11 May 2026 22:18:34 +0200 Date: Mon, 11 May 2026 22:18:34 +0200 From: Andrew Lunn To: Selvamani Rajagopal Cc: Piergiorgio Beruto , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v2 8/9] onsemi: s2500: Add driver support for TS2500 MAC-PHY Message-ID: <657612fb-747f-4506-8a7f-e9536d7c4c2b@lunn.ch> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > +static u32 phy_addr_list[S2500_NUM_REGS] = { > + (0x4 << 16) | 0x8000, > + (0xC << 16) | 0x10, Is 4 OA_TC6_PHY_C45_VS_PLCA_MMS4? 0xC is your vendor 1? These should probably be moved somewhere public: #define OA_TC6_PHY_C45_PCS_MMS2 2 /* MMD 3 */ #define OA_TC6_PHY_C45_PMA_PMD_MMS3 3 /* MMD 1 */ #define OA_TC6_PHY_C45_VS_PLCA_MMS4 4 /* MMD 31 */ #define OA_TC6_PHY_C45_AUTO_NEG_MMS5 5 /* MMD 7 */ #define OA_TC6_PHY_C45_POWER_UNIT_MMS6 6 /* MMD 13 */ and think about how you can represent 12 using a #define. Andrew