From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eWH6oA5w" Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E8C8E3; Wed, 13 Dec 2023 08:26:48 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-336420a244dso477400f8f.0; Wed, 13 Dec 2023 08:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702484807; x=1703089607; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=86rjT9r43JxUHVqCjIMaYs/7Gsf2BMQ04Q05TfKC+5o=; b=eWH6oA5wx3EmMj5NFX8Nk+naIAzSf9xFR5k4eFZQDsvXpJAENOBWBenyltoGnX9XVM +Vt1eGvp9AjJFDUidC2QmVqK+eqW8djbIHwsduYv6Wqsgk3YjjcKaxDS9H3XsEGbQJqC c4OJFGzOxYKeEoaiY5IK8HGpiCGoQeBy3aOUWH0CqbY8QulSwMoNFa4ZaxhnnGWUNwra euTHFQ3YarrRQRAshlhs75aH2m5t/4RnY69l3S6LeAMD8PZ3QcjFuqIG6+pPaipeQ3eQ kIWiJ3X0Bm+rN0fY09hzDTnHsUmJmqMEUbDqhxTLAdszfcGi8IsJinNiJ7+oGPdbvlER IY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702484807; x=1703089607; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=86rjT9r43JxUHVqCjIMaYs/7Gsf2BMQ04Q05TfKC+5o=; b=V8BewCm1TIfKpjW6iRjstY9W6oFL/39MYiPuGiNi9AufbKAZROuyqppCYR+Yct2gZZ DDfkZ4w00FFvyrWtxosO0c/Hp7VIt6Usk87Fbvb56GDDLkFBlh8yZr0/I1xR+rdkFTV7 wHycl4wHvKve77qEauQwsETQoxm8xos62jAkp0JzFBeVMcQBYCapn0MYTATJE270vFSh LupRgmcaym88cMh/3+w7t73XGTufvcEltcOeC/2lRJGTORtr4RynwP/SaTU3caMvhOvZ 9ACQy3FS9lSyh8UN2a2guHhYTNs/UbTKjTeKJ1gQmtgC3hvwMgIGLjNL12SVDlo+HQfD Ufmg== X-Gm-Message-State: AOJu0YwdMOU8gqWAT8ssxAK49uoobgJ5HPnt5xfQ7qIJeRHh/w9i4odg 8EI17KnN9w6UykmbpY+PQjM= X-Google-Smtp-Source: AGHT+IG3J3ozT4pM9XLZHmjeZXoiiA+xGV9gq0CLTjcYh08vAtBidQZZbRv0vSgmwbthR08Q89v97w== X-Received: by 2002:a5d:63cf:0:b0:333:3a3b:8b9b with SMTP id c15-20020a5d63cf000000b003333a3b8b9bmr3811893wrw.108.1702484806570; Wed, 13 Dec 2023 08:26:46 -0800 (PST) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id c13-20020a5d4ccd000000b003363823d8aesm2291005wrt.59.2023.12.13.08.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:26:46 -0800 (PST) Message-ID: <6579db46.5d0a0220.d624a.80b4@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 13 Dec 2023 17:26:43 +0100 From: Christian Marangi To: "Russell King (Oracle)" Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , David Epping , Harini Katakam , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v6 3/3] net: phy: add support for PHY package MMD read/write References: <20231213105730.1731-1-ansuelsmth@gmail.com> <20231213105730.1731-3-ansuelsmth@gmail.com> <6579d3df.050a0220.41f9b.a309@mx.google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 13, 2023 at 04:13:28PM +0000, Russell King (Oracle) wrote: > On Wed, Dec 13, 2023 at 04:55:08PM +0100, Christian Marangi wrote: > > On Wed, Dec 13, 2023 at 03:47:19PM +0000, Russell King (Oracle) wrote: > > > On Wed, Dec 13, 2023 at 11:57:30AM +0100, Christian Marangi wrote: > > > > Some PHY in PHY package may require to read/write MMD regs to correctly > > > > configure the PHY package. > > > > > > > > Add support for these additional required function in both lock and no > > > > lock variant. > > > > > > > > It's assumed that the entire PHY package is either C22 or C45. We use > > > > C22 or C45 way of writing/reading to mmd regs based on the passed phydev > > > > whether it's C22 or C45. > > > > > > > > Signed-off-by: Christian Marangi > > > > > > I don't recall what has been said in previous postings of this, but > > > introducing new helpers without an example user is normally frowned > > > upon. The lack of cover message for this three patch series also > > > doesn't help (the cover message could explain why there's no users > > > being proposed with this addition of helpers.) > > > > > > > These are prereq for the qca803x PHY driver and the PHY package series. > > > > I can move this single patch in those series, but it was suggested to > > move these simple change to a separate patch to lower the patch number > > since they were orthogonal to the PHY package series proposal. > > ... so adding a cover message (your series in general seem to lack > those) would be a good idea to explain that. > I tend to use cover letters only for big series, sorry for not being very clear about this. Soo should I detach this from here or it O.K.? -- Ansuel