From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3967CC43381 for ; Thu, 21 Mar 2019 17:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B31D2190A for ; Thu, 21 Mar 2019 17:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="B/z+d9oI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728616AbfCURPp (ORCPT ); Thu, 21 Mar 2019 13:15:45 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:36228 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728157AbfCURPp (ORCPT ); Thu, 21 Mar 2019 13:15:45 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2LHDWK4144292; Thu, 21 Mar 2019 17:15:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=1tphgY6iaDKhGw+L6acl2Uip2JlAeNIkYdnRB04mH+s=; b=B/z+d9oIjaMYCjtxvAQhcdOgy+pqk0LrQbJp0Z9Fo9bJ/IteXincv57G3r1tHdK7RPXv gsvPJ7pUIrCWkG1ZDxa/9QRS+Aq95V7j4B/ArBLUQqNZ5vfDD/XRa3BY6CCzNvrnv3ly qMidwxySGMa0AURd3b2MzsMHtLHy79EBWMlei10FPOUgayNn0YodWI/OQx6PQpc0Sw9c x2hEXalVB49oCIeeGX8PZITBJyad8aq0ZmhN1drEjWeeLhVUZZc5WGnvQCPjG+e4F8px pYawf47A9XIi1/hMM0sld8MlmT986RSouWw42PAO39pMDqOP4MfXIMaA+8ZWRf1UPjPS tg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2r8ssrsmv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 17:15:33 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2LHFRHC010150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Mar 2019 17:15:27 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2LHFR5t009559; Thu, 21 Mar 2019 17:15:27 GMT Received: from [10.30.3.18] (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 21 Mar 2019 10:15:27 -0700 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Subject: Re: [summary] virtio network device failover writeup From: Liran Alon In-Reply-To: <20190321131006-mutt-send-email-mst@kernel.org> Date: Thu, 21 Mar 2019 19:15:19 +0200 Cc: Stephen Hemminger , Si-Wei Liu , Sridhar Samudrala , Alexander Duyck , Jakub Kicinski , Jiri Pirko , David Miller , Netdev , virtualization@lists.linux-foundation.org, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com, jfreimann@redhat.com, ogerlitz@mellanox.com, vuhuong@mellanox.com Content-Transfer-Encoding: quoted-printable Message-Id: <65C9DA4E-D959-4F9D-AD5B-1831387E652E@oracle.com> References: <20190321044920-mutt-send-email-mst@kernel.org> <20190321082532-mutt-send-email-mst@kernel.org> <20190321085159-mutt-send-email-mst@kernel.org> <2939FB15-720A-4C9E-92B7-2DBA139DDE0F@oracle.com> <20190321084517.773a65fa@shemminger-XPS-13-9360> <20190321114557-mutt-send-email-mst@kernel.org> <20190321131006-mutt-send-email-mst@kernel.org> To: "Michael S. Tsirkin" X-Mailer: Apple Mail (2.3445.4.7) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9202 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903210122 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On 21 Mar 2019, at 19:12, Michael S. Tsirkin wrote: >=20 > On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote: >>=20 >>=20 >>> On 21 Mar 2019, at 17:50, Michael S. Tsirkin wrote: >>>=20 >>> On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote: >>>> On Thu, 21 Mar 2019 15:04:37 +0200 >>>> Liran Alon wrote: >>>>=20 >>>>>>=20 >>>>>> OK. Now what happens if master is moved to another namespace? Do = we need >>>>>> to move the slaves too? =20 >>>>>=20 >>>>> No. Why would we move the slaves? The whole point is to make most = customer ignore the net-failover slaves and remain them =E2=80=9Chidden=E2= =80=9D in their dedicated netns. >>>>> We won=E2=80=99t prevent customer from explicitly moving the = net-failover slaves out of this netns, but we will not move them out of = there automatically. >>>>=20 >>>>=20 >>>> The 2-device netvsc already handles case where master changes = namespace. >>>=20 >>> Is it by moving slave with it? >>=20 >> See c0a41b887ce6 ("hv_netvsc: move VF to same namespace as netvsc = device=E2=80=9D). >> It seems that when NetVSC master netdev changes netns, the VF is = moved to the same netns by the NetVSC driver. >> Kinda the opposite than what we are suggesting here to make sure that = the net-failover master netdev is on a separate >> netns than it=E2=80=99s slaves... >>=20 >> -Liran >>=20 >>>=20 >>> --=20 >>> MST >=20 > Not exactly opposite I'd say. >=20 > If failover is in host ns, slaves in /primary and /standby, then = moving > failover to /container should move slaves to /container/primary and > /container/standby. Yes I agree. I meant that they tried to keep the VF on the same netns as the NetVSC. But of course what you just described is exactly the functionality I = would have wanted in our net-failover mechanism. -Liran >=20 >=20 > --=20 > MST