From: John Fastabend <john.fastabend@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Cc: netdev@vger.kernel.org, eadavis@qq.com, bpf@vger.kernel.org,
borisp@nvidia.com
Subject: Re: [PATCH net 2/2] net: tls, add test to capture error on large splice
Date: Fri, 12 Jan 2024 13:52:42 -0800 [thread overview]
Message-ID: <65a1b4aabc0ff_4054208c2@john.notmuch> (raw)
In-Reply-To: <20240111170548.59d248f6@kernel.org>
Jakub Kicinski wrote:
> On Wed, 10 Jan 2024 14:01:24 -0800 John Fastabend wrote:
> > + EXPECT_EQ(splice(p[0], NULL, self->fd, NULL, send_pipe, 0xe), 1);
>
> Any reason to use 0xe rather than the SPLICE_F_* defines for flags?
No reason I crafted the test first and then forgot to come back
and tidy it much.
I'll send a v2 with readable names.
prev parent reply other threads:[~2024-01-12 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 22:01 [PATCH net 0/2] tls fixes for SPLICE with more hint John Fastabend
2024-01-10 22:01 ` [PATCH net 1/2] net: tls, fix WARNIING in __sk_msg_free John Fastabend
2024-01-12 1:05 ` Jakub Kicinski
2024-01-10 22:01 ` [PATCH net 2/2] net: tls, add test to capture error on large splice John Fastabend
2024-01-12 1:05 ` Jakub Kicinski
2024-01-12 21:52 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a1b4aabc0ff_4054208c2@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=borisp@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=eadavis@qq.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).