From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave Date: Thu, 9 Mar 2017 08:50:14 -0800 Message-ID: <65ac3de8-9fdd-b5c5-b7aa-aa4393626551@oracle.com> References: <1489044405-26150-1-git-send-email-yanjun.zhu@oracle.com> <1489044405-26150-2-git-send-email-yanjun.zhu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Zhu Yanjun , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org Return-path: In-Reply-To: <1489044405-26150-2-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 3/8/2017 11:26 PM, Zhu Yanjun wrote: > It is difficult to make sure the state of the interrupt when this > function is called. As such, it is safer to use spin_lock_irqsave > than spin_lock_irq. > There is no reason to hold irqs and as such the code path is safe from irq context. I don't see need of this change unless you have test case which showed some issue. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html