From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
Date: Thu, 08 Feb 2024 18:46:48 -0500 [thread overview]
Message-ID: <65c567e869ea6_28ece2945c@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240208153440.590685bb@kernel.org>
Jakub Kicinski wrote:
> On Thu, 08 Feb 2024 15:51:31 -0500 Willem de Bruijn wrote:
> > Paolo Abeni wrote:
> > > This test is time sensitive. It may fail on virtual machines and for
> > > debug builds.
> > >
> > > Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> > > so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> > > errors (only).
> > >
> > > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> >
> > Is this still failing after commit 5264ab612e28
> > ("selftests/net: calibrate txtimestamp")?
>
> On a debug kernel it continues to flake :(
>
> https://netdev.bots.linux.dev/flakes.html?br-cnt=80&tn-needle=txtimestamp&min-flip=0
Thanks. I should have checked the dash directly. Reminder for next time.
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2024-02-08 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:57 [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW Paolo Abeni
2024-02-08 20:51 ` Willem de Bruijn
2024-02-08 23:34 ` Jakub Kicinski
2024-02-08 23:46 ` Willem de Bruijn [this message]
2024-02-12 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65c567e869ea6_28ece2945c@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).