From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on
 bound sockets
Date: Mon, 4 Jun 2018 10:24:13 -0700
Message-ID: <65de8d5d-b24b-1755-1268-e36a3d9306c2@gmail.com>
References: <20180603174705.51802-1-zenczykowski@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org
To: =?UTF-8?Q?Maciej_=c5=bbenczykowski?= <zenczykowski@gmail.com>,
        =?UTF-8?Q?Maciej_=c5=bbenczykowski?= <maze@google.com>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f196.google.com ([209.85.192.196]:43372 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750865AbeFDRYP (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Jun 2018 13:24:15 -0400
Received: by mail-pf0-f196.google.com with SMTP id j20-v6so16361344pff.10
        for <netdev@vger.kernel.org>; Mon, 04 Jun 2018 10:24:15 -0700 (PDT)
In-Reply-To: <20180603174705.51802-1-zenczykowski@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/03/2018 10:47 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
> 
> It is not safe to do so because such sockets are already in the
> hash tables and changing these options can result in invalidating
> the tb->fastreuse(port) caching.
> 

Reviewed-by: Eric Dumazet <edumazet@google.com>