* [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier
@ 2024-03-07 16:29 Eric Dumazet
2024-03-07 20:26 ` Willem de Bruijn
2024-03-08 21:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2024-03-07 16:29 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: David Ahern, netdev, eric.dumazet, Eric Dumazet
There is no point cloning an skb and having to free the clone
if the receive queue of the raw socket is full.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/ipv6/raw.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 779274055abf99530048ad4738c2263e97c94cce..ca49e6617afaff3fe6c5f3a174bbe6d96f94ac62 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -160,6 +160,13 @@ static bool ipv6_raw_deliver(struct sk_buff *skb, int nexthdr)
if (!raw_v6_match(net, sk, nexthdr, daddr, saddr,
inet6_iif(skb), inet6_sdif(skb)))
continue;
+
+ if (atomic_read(&sk->sk_rmem_alloc) >=
+ READ_ONCE(sk->sk_rcvbuf)) {
+ atomic_inc(&sk->sk_drops);
+ continue;
+ }
+
delivered = true;
switch (nexthdr) {
case IPPROTO_ICMPV6:
--
2.44.0.278.ge034bb2e1d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier
2024-03-07 16:29 [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier Eric Dumazet
@ 2024-03-07 20:26 ` Willem de Bruijn
2024-03-08 21:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2024-03-07 20:26 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: David Ahern, netdev, eric.dumazet, Eric Dumazet
Eric Dumazet wrote:
> There is no point cloning an skb and having to free the clone
> if the receive queue of the raw socket is full.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier
2024-03-07 16:29 [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier Eric Dumazet
2024-03-07 20:26 ` Willem de Bruijn
@ 2024-03-08 21:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-08 21:20 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, dsahern, netdev, eric.dumazet
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 7 Mar 2024 16:29:43 +0000 you wrote:
> There is no point cloning an skb and having to free the clone
> if the receive queue of the raw socket is full.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv6/raw.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Here is the summary with links:
- [net-next] ipv6: raw: check sk->sk_rcvbuf earlier
https://git.kernel.org/netdev/net-next/c/026763ece881
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-08 21:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-07 16:29 [PATCH net-next] ipv6: raw: check sk->sk_rcvbuf earlier Eric Dumazet
2024-03-07 20:26 ` Willem de Bruijn
2024-03-08 21:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).