From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Wippel Subject: Re: [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid_attr Date: Wed, 22 Aug 2018 16:19:37 +0200 Message-ID: <6612bff3-63cb-6353-a8fa-a7c8a1995e2b@linux.ibm.com> References: <20180818021707.GA25026@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-rdma@vger.kernel.org, Parav Pandit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Jason Gunthorpe , Ursula Braun Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57136 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729237AbeHVRou (ORCPT ); Wed, 22 Aug 2018 13:44:50 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7MEJWwN101970 for ; Wed, 22 Aug 2018 10:19:43 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m17prw21v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Aug 2018 10:19:43 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Aug 2018 15:19:41 +0100 In-Reply-To: <20180818021707.GA25026@ziepe.ca> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 08/18/2018 04:17 AM, Jason Gunthorpe wrote: > All RDMA ULPs should be using rdma_get_gid_attr instead of > ib_query_gid. Convert SMC to use the new API. > > In the process correct some confusion with gid_type - if attr->ndev is > !NULL then gid_type can never be IB_GID_TYPE_IB by > definition. IB_GID_TYPE_ROCE shares the same enum value and is probably > what was intended here. > > Reviewed-by: Parav Pandit > Signed-off-by: Jason Gunthorpe I ran a few SMC tests and the changes look good. So, no objections from our side and thank you for the patch. Hans