From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Elwell Subject: Re: [PATCH] lan78xx: Correctly indicate invalid OTP Date: Wed, 11 Apr 2018 14:03:36 +0100 Message-ID: <6615a0eb-a0f4-d964-bab7-e2105b589f3d@raspberrypi.org> References: <1523440757-127451-1-git-send-email-phil@raspberrypi.org> <20180411125737.GB6119@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Woojung Huh , Microchip Linux Driver Support , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Lunn Return-path: In-Reply-To: <20180411125737.GB6119@lunn.ch> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Andrew. On 11/04/2018 13:57, Andrew Lunn wrote: > On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote: >> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP >> content, but the value gets overwritten before it is returned and the >> read goes ahead anyway. Make the read conditional as it should be >> and preserve the error code. > > Hi Phil > > Do you know that the Fixes: tag should be for this? When did it break? It's been broken since day 1, so: Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")