From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, John Fraker <jfraker@google.com>
Cc: netdev@vger.kernel.org,
Praveen Kaligineedi <pkaligineedi@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Shailend Chand <shailend@google.com>,
Willem de Bruijn <willemb@google.com>,
"David S. Miller" <davem@davemloft.net>,
Junfeng Guo <junfeng.guo@intel.com>,
Ziwei Xiao <ziweixiao@google.com>,
Jeroen de Borst <jeroendb@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] gve: Correctly report software timestamping capabilities
Date: Wed, 10 Apr 2024 23:22:00 -0400 [thread overview]
Message-ID: <66175758bab7c_2dcc3c294a@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240409172602.3284f1c6@kernel.org>
Jakub Kicinski wrote:
> On Mon, 8 Apr 2024 11:09:01 -0700 John Fraker wrote:
> > gve has supported software timestamp generation since its inception,
> > but has not advertised that support via ethtool. This patch correctly
> > advertises that support.
> >
> > Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
> > Signed-off-by: John Fraker <jfraker@google.com>
>
> I think it should be a single line diff:
>
> + .get_ts_info = ethtool_op_get_ts_info,
>
> right?
If inserted above .get_link_ksettings that works. The current
ordering is not based on actual struct layout anyway.
Probably all statements should just end in a comma, including a
trailing comma. To avoid these two line changes on each subsequent
change.
The rest of the discussion in this thread is actually quite
unrelated to this patch. Didn't meant to sidetrack that.
next prev parent reply other threads:[~2024-04-11 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 18:09 [PATCH net-next] gve: Correctly report software timestamping capabilities John Fraker
2024-04-09 14:29 ` Willem de Bruijn
2024-04-10 0:28 ` Jakub Kicinski
2024-04-10 4:40 ` Rahul Rameshbabu
2024-04-10 13:19 ` Jakub Kicinski
2024-04-10 19:31 ` Willem de Bruijn
2024-04-11 0:40 ` Rahul Rameshbabu
2024-04-11 1:36 ` Willem de Bruijn
2024-04-10 0:26 ` Jakub Kicinski
2024-04-11 3:22 ` Willem de Bruijn [this message]
2024-04-11 19:37 ` John Fraker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66175758bab7c_2dcc3c294a@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=junfeng.guo@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox