From: Heiner Kallweit <hkallweit1@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH RFC v2 0/7] net: phy: patch series aiming to improve few aspects of phylib
Date: Fri, 16 Mar 2018 22:04:42 +0100 [thread overview]
Message-ID: <6618f53c-778a-cb12-deb4-c618a728b43e@gmail.com> (raw)
This patch series aims to tackle few issues with phylib:
- address issues with patch series [1] (smsc911x + phylib changes)
- make phy_stop synchronous
- get rid of phy_start/stop_machine and handle it in phy_start/phy_stop
- in mdio_suspend consider runtime pm state of mdio bus parent
- consider more WOL conditions when deciding whether PHY is allowed to
suspend
- only resume phy after system suspend if needed
[1] https://www.mail-archive.com/netdev@vger.kernel.org/msg196061.html
It works fine here but other NIC drivers may use phylib differently.
Therefore I'd appreciate feedback and more testing.
I could think of some subsequent patches, e.g. phy_error() could be
reduced to calling phy_stop() and printing an error message
(today it silently sets the PHY state to PHY_HALTED).
Changes in v2:
- Incorporate review comments
- Address error reported by Geert by changing phy_stop() to not trigger
a linkwatch event.
Heiner Kallweit (7):
net: phy: unconditionally resume and re-enable interrupts in phy_start
net: phy: improve checking for when PHY is allowed to suspend
net: phy: resume PHY only if needed in mdio_bus_phy_suspend
net: phy: remove phy_start_machine
net: phy: make phy_stop synchronous
net: phy: use new function phy_stop_suspending in mdio_bus_phy_suspend
net: phy: remove phy_stop_machine
drivers/net/phy/phy.c | 127 +++++++++++++++++++++----------------------
drivers/net/phy/phy_device.c | 77 ++++++++++++++++----------
drivers/net/phy/phylink.c | 1 -
include/linux/phy.h | 3 +-
4 files changed, 112 insertions(+), 96 deletions(-)
--
2.16.2
next reply other threads:[~2018-03-16 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 21:04 Heiner Kallweit [this message]
2018-03-16 21:14 ` [PATCH RFC v2 1/7] net: phy: unconditionally resume and re-enable interrupts, in phy_start Heiner Kallweit
2018-03-16 21:14 ` [PATCH RFC v2 2/7] net: phy: improve checking for when PHY is allowed to, suspend Heiner Kallweit
2018-03-16 21:15 ` [PATCH RFC v2 3/7] net: phy: resume PHY only if needed in mdio_bus_phy_suspend Heiner Kallweit
2018-03-16 21:15 ` [PATCH RFC v2 4/7] net: phy: remove phy_start_machine Heiner Kallweit
2018-03-16 21:23 ` [PATCH RFC v2 5/7] net: phy: make phy_stop synchronous Heiner Kallweit
2018-03-16 21:24 ` [PATCH RFC v2 6/7] net: phy: use new function phy_stop_suspending in mdio_bus_phy_suspend Heiner Kallweit
2018-03-16 21:25 ` [PATCH RFC v2 7/7] net: phy: remove phy_stop_machine Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6618f53c-778a-cb12-deb4-c618a728b43e@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).