From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
andrew@lunn.ch, Woojung.Huh@microchip.com, mlxsw@mellanox.com
Subject: Re: [PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup
Date: Mon, 7 Aug 2017 11:48:57 -0700 [thread overview]
Message-ID: <661b19a4-5c49-6ab1-41fe-fab83aa64572@gmail.com> (raw)
In-Reply-To: <87bmnrifte.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 08/07/2017 07:59 AM, Vivien Didelot wrote:
> Hi Arkadi,
>
> Arkadi Sharshevsky <arkadis@mellanox.com> writes:
>
>> The patchset adds support for configuring static FDB entries via the
>> switchdev notification chain. The current method for FDB configuration
>> uses the switchdev's bridge bypass implementation. In order to support
>> this legacy way and to perform the switchdev cleanup, the implementation
>> is moved inside DSA.
>>
>> The DSA drivers cannot sync the software bridge with hardware learned
>> entries and use the switchdev's implementation of bypass FDB dumping.
>> Because they are the only ones using this functionality, the fdb_dump
>> implementation is moved from switchdev code into DSA.
>>
>> Finally after this changes a major cleanup in switchdev can be done.
>> ---
>> Please see individual patches for patch specific change logs.
>> v1->v2
>> - Split MDB/vlan dump removal into core/driver removal.
>>
>> v2->v3
>> - The self implementation for FDB add/del is moved inside DSA.
>
> v3 behaves correctly:
>
> # bridge fdb add e4:1d:2d:a5:f0:2a dev lan3
> # bridge fdb add e4:1d:2d:a5:f0:4a dev lan4 master
> # bridge fdb show
> 01:00:5e:00:00:01 dev eth0 self permanent
> 01:00:5e:00:00:01 dev eth1 self permanent
> b6:f2:c8:3a:1c:71 dev lan0 master br0 permanent
> e4:1d:2d:a5:f0:2a dev lan3 self static
> e4:1d:2d:a5:f0:4a dev lan4 offload master br0 permanent
> e4:1d:2d:a5:f0:4a dev lan4 self static
> 01:00:5e:00:00:01 dev br0 self permanent
> # bridge fdb del e4:1d:2d:a5:f0:2a dev lan3
> # bridge fdb del e4:1d:2d:a5:f0:4a dev lan4 master
> # bridge fdb show
> 01:00:5e:00:00:01 dev eth0 self permanent
> 01:00:5e:00:00:01 dev eth1 self permanent
> b6:f2:c8:3a:1c:71 dev lan0 master br0 permanent
> 01:00:5e:00:00:01 dev br0 self permanent
>
> Tested-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Same here:
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
thanks!
--
Florian
next prev parent reply other threads:[~2017-08-07 18:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 13:15 [PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup Arkadi Sharshevsky
2017-08-06 13:15 ` [PATCH net-next v3 01/13] net: dsa: Change DSA slave FDB API to be switchdev independent Arkadi Sharshevsky
2017-08-06 13:15 ` [PATCH net-next v3 02/13] net: dsa: Remove prepare phase for FDB Arkadi Sharshevsky
2017-08-06 13:15 ` [PATCH net-next v3 03/13] net: dsa: Remove switchdev dependency from DSA switch notifier chain Arkadi Sharshevsky
2017-08-06 13:15 ` [PATCH net-next v3 04/13] net: dsa: Add support for learning FDB through notification Arkadi Sharshevsky
2017-08-07 18:07 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 05/13] net: dsa: Move FDB add/del implementation inside DSA Arkadi Sharshevsky
2017-08-07 13:56 ` Vivien Didelot
2017-08-07 18:08 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 06/13] net: dsa: Add support for querying supported bridge flags Arkadi Sharshevsky
2017-08-07 18:01 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 07/13] net: dsa: Remove support for vlan dump from DSA's drivers Arkadi Sharshevsky
2017-08-07 18:09 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 08/13] net: dsa: Remove support for bypass bridge port attributes/vlan set Arkadi Sharshevsky
2017-08-07 18:09 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 09/13] net: dsa: Remove support for MDB dump from DSA's drivers Arkadi Sharshevsky
2017-08-07 18:09 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 10/13] net: dsa: Remove redundant MDB dump support Arkadi Sharshevsky
2017-08-07 18:04 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 11/13] net: dsa: Move FDB dump implementation inside DSA Arkadi Sharshevsky
2017-08-06 13:15 ` [PATCH net-next v3 12/13] net: bridge: Remove FDB deletion through switchdev object Arkadi Sharshevsky
2017-08-07 10:31 ` Ivan Vecera
2017-08-07 10:36 ` Jiri Pirko
2017-08-07 18:12 ` Florian Fainelli
2017-08-06 13:15 ` [PATCH net-next v3 13/13] net: switchdev: Remove bridge bypass support from switchdev Arkadi Sharshevsky
2017-08-07 10:26 ` Jiri Pirko
2017-08-07 10:31 ` Ivan Vecera
2017-08-07 18:13 ` Florian Fainelli
2017-08-07 14:59 ` [PATCH net-next v3 00/13] Update DSA's FDB API and perform switchdev cleanup Vivien Didelot
2017-08-07 18:48 ` Florian Fainelli [this message]
2017-08-07 21:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661b19a4-5c49-6ab1-41fe-fab83aa64572@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).