From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Yick Xie <yick.xie@gmail.com>,
willemdebruijn.kernel@gmail.com, willemb@google.com
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net] udp: don't be set unconnected if only UDP cmsg
Date: Mon, 15 Apr 2024 10:11:15 -0400 [thread overview]
Message-ID: <661d3583a289e_c0c8294c1@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240414195213.106209-1-yick.xie@gmail.com>
Yick Xie wrote:
> If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
> "connected" should not be set to 0. Otherwise it stops
> the connected socket from using the cached route.
>
> Signed-off-by: Yick Xie <yick.xie@gmail.com>
This either needs to target net-next, or have
Fixes: 2e8de8576343 ("udp: add gso segment cmsg")
I think it can be argued either way. This situation existed from the
start, and is true for other cmsg that don't affect routing as well.
If the impact of the route lookup is significant, it couls be argued
to be a performance bug.
I steer towards net-next. In which case it would be nice to also
move the ipc.opt branch and perhaps even exclude other common cmsgs,
such as SCM_TXTIME and SCM_TIMESTAMPING.
next prev parent reply other threads:[~2024-04-15 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 19:52 [PATCH net] udp: don't be set unconnected if only UDP cmsg Yick Xie
2024-04-15 14:11 ` Willem de Bruijn [this message]
2024-04-15 23:30 ` Yick Xie
2024-04-16 14:51 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661d3583a289e_c0c8294c1@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=yick.xie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).