From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org,
aleksander.lobakin@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1 2/2] net: gro: add p_off param in *_gro_complete
Date: Thu, 18 Apr 2024 14:40:44 -0400 [thread overview]
Message-ID: <6621692cbedd1_f648a29469@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <6736050b-1410-453e-8afa-55e4c8f34033@gmail.com>
Richard Gobert wrote:
> Willem de Bruijn wrote:> Since this INDIRECT_CALL_INET needs to know about the definitions of
> > udp4_lib_lookup_skb and udp6_lib_lookup_skb anyway, we can just get
> > rid of the whole udp_lookup_t type and function pointer passing?
> >
> > Or move the entire lookup to udp4_gro_complete/udp6_gro_complete and
> > pass the sk to udp_gro_complete.
>
> This sounds like a really good idea, I like it. Although I think it may be
> more relevant to net-next instead of this bug fix. I can post a
> complementing patch to net-next later if that's OK with you
That's fine.
This patch as is is already very intrusive for a net patch. For a fix,
could we do something smaller? Like add the network offset into
NAPI_GRO_CB in inet_gro_callback and use that in udp4_lib_lookup_skb?
(and same for IPv6 of course).
next prev parent reply other threads:[~2024-04-18 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:21 [PATCH net v1 0/2] net: gro: add flush/flush_id checks and fix wrong offset in udp Richard Gobert
2024-04-12 15:21 ` [PATCH net v1 1/2] net: gro: add flush check in udp_gro_receive_segment Richard Gobert
2024-04-13 18:38 ` Willem de Bruijn
2024-04-14 17:22 ` Alexander Duyck
2024-04-15 15:00 ` Willem de Bruijn
2024-04-15 15:19 ` Alexander Duyck
2024-04-15 15:35 ` Willem de Bruijn
2024-04-12 15:21 ` [PATCH net v1 2/2] net: gro: add p_off param in *_gro_complete Richard Gobert
2024-04-13 18:46 ` Willem de Bruijn
2024-04-17 13:48 ` Richard Gobert
2024-04-17 19:39 ` Willem de Bruijn
2024-04-18 15:12 ` Richard Gobert
2024-04-18 18:40 ` Willem de Bruijn [this message]
2024-04-19 15:17 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6621692cbedd1_f648a29469@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).