public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonas Gorski <jonas.gorski@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Louis Scalbert <louis.scalbert@6wind.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, jv@jvosburgh.net,
	edumazet@google.com, pabeni@redhat.com, fbl@redhat.com,
	andy@greyhouse.net, shemminger@vyatta.com, maheshb@google.com
Subject: Re: [PATCH net v3 0/5] bonding: 3ad: fix carrier state with no valid slaves
Date: Thu, 9 Apr 2026 08:53:10 +0200	[thread overview]
Message-ID: <6631e1e7-8728-46a4-9999-ea9910a1abfb@gmail.com> (raw)
In-Reply-To: <20260408201341.68f31247@kernel.org>

On 09/04/2026 05:13, Jakub Kicinski wrote:
> On Wed,  8 Apr 2026 17:23:48 +0200 Louis Scalbert wrote:
>> The current behavior is not compliant with the LACP standard. This
>> patchset introduces a working behavior that is not strictly
>> standard-compliant either, but is widely adopted across the industry.
>> It consists of bringing the bonding master interface down to signal to
>> upper-layer processes that it is not usable.
> 
> Is the only problem the compliance? If so I don't think this qualifies
> as a fix. Please drop the Fixes tags and repost for net-next. Please
> keep in mind the 24h reposting period (also I need some time tomorrow
> to queue your patch to the CI so that the selftest passes when v4 is
> posted :()

Signalling link up too early can cause issues for some protocols that
may change behavior in the absence of PDUs from a link partner.

E.g. AFAIU RSTP may decide the bond is an edge port because no RSTP
BPDUs received and put the bond in forwarding, which then temporarily
creates a loop once the bond actually starts forwarding packets (until
it receives the next RSTP BPDU, which may take up to two seconds).

Best regards,
Jonas

      reply	other threads:[~2026-04-09  6:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 15:23 [PATCH net v3 0/5] bonding: 3ad: fix carrier state with no valid slaves Louis Scalbert
2026-04-08 15:23 ` [PATCH net v3 1/5] bonding: 3ad: add lacp_fallback configuration knob Louis Scalbert
2026-04-08 15:23 ` [PATCH net v3 2/5] bonding: 3ad: fix carrier when no valid slaves Louis Scalbert
2026-04-08 15:23 ` [PATCH net v3 3/5] bonding: 3ad: fix mux port state on oper down Louis Scalbert
2026-04-08 15:23 ` [PATCH net v3 4/5] bonding: 3ad: fix stuck negotiation on recovery Louis Scalbert
2026-04-08 15:23 ` [PATCH net v3 5/5] selftests: bonding: add test for fallback mode Louis Scalbert
2026-04-09  3:13 ` [PATCH net v3 0/5] bonding: 3ad: fix carrier state with no valid slaves Jakub Kicinski
2026-04-09  6:53   ` Jonas Gorski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6631e1e7-8728-46a4-9999-ea9910a1abfb@gmail.com \
    --to=jonas.gorski@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=edumazet@google.com \
    --cc=fbl@redhat.com \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=louis.scalbert@6wind.com \
    --cc=maheshb@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox