From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result
Date: Thu, 13 Oct 2016 07:54:52 -0400 [thread overview]
Message-ID: <66664527-cd40-453b-7130-7447e4c6083d@mojatatu.com> (raw)
In-Reply-To: <1476344769.5650.25.camel@edumazet-glaptop3.roam.corp.google.com>
On 16-10-13 03:46 AM, Eric Dumazet wrote:
> On Wed, 2016-10-12 at 09:36 -0700, Cong Wang wrote:
>> On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>> + if (unicast)
>>> + return netlink_unicast(net->rtnl, skb, portid, MSG_DONTWAIT);
>>
>> Nit: rtnl_unicast() is simpler.
>
> I copied code in rtnetlink_send(), I guess we could use rtnl_unicast()
> there as well.
I would toss a coin and if it lands on tail then make the change ;->
(probably in a separate patch).
cheers,
jamal
next prev parent reply other threads:[~2016-10-13 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 3:25 [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result Eric Dumazet
2016-10-10 13:16 ` Jamal Hadi Salim
2016-10-12 16:36 ` Cong Wang
2016-10-13 7:46 ` Eric Dumazet
2016-10-13 11:54 ` Jamal Hadi Salim [this message]
2016-10-13 13:54 ` David Miller
2016-10-13 21:08 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66664527-cd40-453b-7130-7447e4c6083d@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox