netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
	 "David S . Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Cc: Ziwei Xiao <ziweixiao@google.com>,
	 Praveen Kaligineedi <pkaligineedi@google.com>,
	 Harshitha Ramamurthy <hramamurthy@google.com>,
	 Willem de Bruijn <willemb@google.com>,
	 Jeroen de Borst <jeroendb@google.com>,
	 Shailend Chand <shailend@google.com>,
	 netdev@vger.kernel.org,  eric.dumazet@gmail.com,
	 Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 0/6] net: ethtool: reduce RTNL pressure in dev_ethtool()
Date: Thu, 20 Jun 2024 13:58:32 -0400	[thread overview]
Message-ID: <66746dc815aa6_2bed872947b@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240620114711.777046-1-edumazet@google.com>

Eric Dumazet wrote:
> This series is inspired by Jakub feedback for one gve patch :
> 
> https://lore.kernel.org/lkml/20240614192721.02700256@kernel.org/
> 
> Refactor dev_ethtool() and start to implement parallel operations.
> 
> Eric Dumazet (6):
>   net: ethtool: grab a netdev reference in dev_ethtool()
>   net: ethtool: add dev_ethtool_cap_check()
>   net: ethtool: perform pm duties outside of rtnl lock
>   net: ethtool: call ethtool_get_one_feature() without RTNL
>   net: ethtool: implement lockless ETHTOOL_GFLAGS
>   net: ethtool: add the ability to run ethtool_[gs]et_rxnfc() without
>     RTNL
> 
>  include/linux/ethtool.h |   2 +
>  net/core/dev.c          |  10 +--
>  net/ethtool/ioctl.c     | 159 ++++++++++++++++++++++++----------------
>  3 files changed, 101 insertions(+), 70 deletions(-)

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks Eric!

One small comment in the ethtool_ops field, but not important.

      parent reply	other threads:[~2024-06-20 17:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 11:47 [PATCH net-next 0/6] net: ethtool: reduce RTNL pressure in dev_ethtool() Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 1/6] net: ethtool: grab a netdev reference " Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 2/6] net: ethtool: add dev_ethtool_cap_check() Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 3/6] net: ethtool: perform pm duties outside of rtnl lock Eric Dumazet
2024-06-21  0:22   ` Jakub Kicinski
2024-06-21  0:59     ` Andrew Lunn
2024-06-21  2:11       ` Jakub Kicinski
2024-06-21  4:16     ` Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 4/6] net: ethtool: call ethtool_get_one_feature() without RTNL Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 5/6] net: ethtool: implement lockless ETHTOOL_GFLAGS Eric Dumazet
2024-06-20 11:47 ` [PATCH net-next 6/6] net: ethtool: add the ability to run ethtool_[gs]et_rxnfc() without RTNL Eric Dumazet
2024-06-20 17:45   ` Willem de Bruijn
2024-06-20 18:29     ` Eric Dumazet
2024-06-20 17:58 ` Willem de Bruijn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66746dc815aa6_2bed872947b@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hramamurthy@google.com \
    --cc=jeroendb@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=shailend@google.com \
    --cc=willemb@google.com \
    --cc=ziweixiao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).