From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in brcmf_sdiod_sglist_rw. Date: Wed, 14 Nov 2018 11:57:13 +0100 Message-ID: <6679c7f3-9df2-1eb0-6f0d-725717460a82@broadcom.com> References: <20181110.163402.130407398146253939.davem@davemloft.net> <9667eb4f-36a1-0439-867b-1defc5946bc2@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: "linux-wireless@vger.kernel.org" To: Andy Duan , David Miller , "netdev@vger.kernel.org" Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:42067 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728141AbeKNVAC (ORCPT ); Wed, 14 Nov 2018 16:00:02 -0500 Received: by mail-pl1-f196.google.com with SMTP id x21-v6so4897170pln.9 for ; Wed, 14 Nov 2018 02:57:17 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 11/14/2018 11:54 AM, Andy Duan wrote: > From: Arend van Spriel [mailto:arend.vanspriel@broadcom.com] Sent: 2018年11月14日 16:40 >> To: Andy Duan ; David Miller >> ; netdev@vger.kernel.org >> Cc: linux-wireless@vger.kernel.org >> Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in >> brcmf_sdiod_sglist_rw. >> >> On 11/14/2018 4:28 AM, Andy Duan wrote: >>> From: David Miller Sent: 2018年11月11日 8:34 >>>> [ As I am trying to remove direct SKB list pointer accesses I am >>>> committing this to net-next. If this causes a lot of grief I >>>> can and will revert, just let me know. ] >> >> [...] >> >>> >>> I just have bcm4339 in hands, test the patch on i.MX7D sdb board with >> bcm4339, it works fine with iperf testing. >>> >>> Tested-by: Fugang Duan >> >> Thanks, Andy >> >> Can you do one more check? Please insert brcmfmac with module parameter >> debug=2 and let me know if the following log message is seen: >> >> brcmfmac: brcmf_sdiod_sgtable_alloc: nents=X >> >> If not seen, the driver does not go through the patched code. > My kernel don't enable debug and DEBUG and CONFIG_BRCM_TRACING, I add the debug info in the brcmf_sdiod_sgtable_alloc(), and the log show the driver go through the sg path: > Log: brcmf_sdiod_sgtable_alloc: max_segs:128, sg_support:1, nents=35 Thanks, Andy Works for me ;-) Regards, Arend