From: David Ahern <dsahern@gmail.com>
To: Stephen Suryaputra <ssuryaextr@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link
Date: Mon, 6 May 2019 13:54:16 -0600 [thread overview]
Message-ID: <667fd9b5-6122-bd9f-e6ae-e08d82197ef9@gmail.com> (raw)
In-Reply-To: <20190506190001.6567-1-ssuryaextr@gmail.com>
On 5/6/19 1:00 PM, Stephen Suryaputra wrote:
> VRF netdev mtu isn't typically set and have an mtu of 65536. When the
> link of a tunnel is set, the tunnel mtu is changed from 1480 to the link
> mtu minus tunnel header. In the case of VRF netdev is the link, then the
> tunnel mtu becomes 65516. So, fix it by not setting the tunnel mtu in
> this case.
>
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
> net/ipv6/sit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index b2109b74857d..971d60bf9640 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1084,7 +1084,7 @@ static void ipip6_tunnel_bind_dev(struct net_device *dev)
> if (!tdev && tunnel->parms.link)
> tdev = __dev_get_by_index(tunnel->net, tunnel->parms.link);
>
> - if (tdev) {
> + if (tdev && !netif_is_l3_master(tdev)) {
> int t_hlen = tunnel->hlen + sizeof(struct iphdr);
>
> dev->hard_header_len = tdev->hard_header_len + sizeof(struct iphdr);
>
can you explain how tdev is a VRF device? What's the config setup for
this case?
next prev parent reply other threads:[~2019-05-06 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 19:00 [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link Stephen Suryaputra
2019-05-06 19:54 ` David Ahern [this message]
2019-05-06 20:28 ` Stephen Suryaputra
2019-05-06 20:33 ` David Ahern
2019-05-07 19:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667fd9b5-6122-bd9f-e6ae-e08d82197ef9@gmail.com \
--to=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).