From: Matthieu Baerts <matttbe@kernel.org>
To: netdev@vger.kernel.org
Cc: mptcp@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Florian Westphal <fw@strlen.de>,
Gang Yan <yangang@kylinos.cn>, Dmytro Shytyi <dmytro@shytyi.net>
Subject: Re: [PATCH net 4/4] mptcp: sockopt: increase seq in mptcp_setsockopt_all_sf
Date: Mon, 4 May 2026 20:08:20 +0200 [thread overview]
Message-ID: <66a22c70-6d8c-4d3b-baa3-b63ca22b804a@kernel.org> (raw)
In-Reply-To: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-4-b70118df778e@kernel.org>
Hello,
On 01/05/2026 21:35, Matthieu Baerts (NGI0) wrote:
> mptcp_setsockopt_all_sf() was missing a call to sockopt_seq_inc(). This
> is required not to cause missing synchronization for newer subflows
> created later on.
>
> This helper is called each time a socket option is set on subflows, and
> future ones will need to inherit this option after their creation.
Regarding Sashiko's review, I think this can be ignored: the comments
are about existing code / architecture. In short, for the moment, most
places in sockopt.c assumes that if there is an error to set a socket
option with one subflow, the error will be visible when setting this
option on all of them. Maybe (not sure) this could be changed, but then
this can be done later, when modifying all the other places. Here I
think it is better to keep the same logic as what is done with the other
options.
https://sashiko.dev/#/patchset/20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e%40kernel.org
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-05-04 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 19:35 [PATCH net 0/4] mptcp: misc fixes for v7.1-rc3 Matthieu Baerts (NGI0)
2026-05-01 19:35 ` [PATCH net 1/4] mptcp: use MPJoinSynAckHMacFailure for SynAck HMAC failure Matthieu Baerts (NGI0)
2026-05-01 19:35 ` [PATCH net 2/4] mptcp: use MPTCP_RST_EMPTCP for ACK HMAC validation failure Matthieu Baerts (NGI0)
2026-05-01 19:35 ` [PATCH net 3/4] mptcp: fix rx timestamp corruption on fastopen Matthieu Baerts (NGI0)
2026-05-01 19:35 ` [PATCH net 4/4] mptcp: sockopt: increase seq in mptcp_setsockopt_all_sf Matthieu Baerts (NGI0)
2026-05-04 18:08 ` Matthieu Baerts [this message]
2026-05-05 2:30 ` [PATCH net 0/4] mptcp: misc fixes for v7.1-rc3 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a22c70-6d8c-4d3b-baa3-b63ca22b804a@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=dmytro@shytyi.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox