From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, dvyukov@google.com
Subject: Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()
Date: Tue, 5 Jun 2018 09:42:54 -0700 [thread overview]
Message-ID: <66acac36-a304-b743-8c6e-ef9cc87366d3@gmail.com> (raw)
In-Reply-To: <20180605.124103.1922429680259846762.davem@davemloft.net>
On 06/05/2018 09:41 AM, David Miller wrote:
> From: Eric Dumazet <edumazet@google.com>
> Date: Tue, 5 Jun 2018 09:25:19 -0700
>
>> It seems that rtnl_group_changelink() can call do_setlink
>> while a prior call to validate_linkmsg(dev = NULL, ...) could
>> not validate IFLA_ADDRESS / IFLA_BROADCAST
>>
>> Make sure do_setlink() calls validate_linkmsg() instead
>> of letting its callers having this responsibility.
>
> But now rtnl_newlink() will validate_linkmsg() twice....
>
Yes, is it a problem ? That is hardly fast path :)
next prev parent reply other threads:[~2018-06-05 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 16:25 [PATCH net-next] rtnetlink: validate attributes in do_setlink() Eric Dumazet
2018-06-05 16:41 ` David Miller
2018-06-05 16:42 ` Eric Dumazet [this message]
2018-06-05 16:45 ` David Miller
2018-06-05 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66acac36-a304-b743-8c6e-ef9cc87366d3@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).