public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>,
	Sabrina Dubroca	 <sd@queasysnail.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman	 <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>, Gang Yan <yangang@kylinos.cn>,
		netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	mptcp@lists.linux.dev
Subject: Re: [PATCH net-next v2] selftests: tls: use mkstemp instead of open(O_TMPFILE)
Date: Mon, 19 Jan 2026 14:16:32 +0800	[thread overview]
Message-ID: <66b44ded1d5174131e90fae85b296ef89a53ab24.camel@kernel.org> (raw)
In-Reply-To: <20260115184922.7e346931@kernel.org>

Hi Jakub, Matt,

On Thu, 2026-01-15 at 18:49 -0800, Jakub Kicinski wrote:
> On Thu, 15 Jan 2026 17:02:40 +0800 Geliang Tang wrote:
> > This is because the /tmp directory uses the virtiofs filesystem,
> > which does
> > not support the O_TMPFILE feature.
> 
> I don't think selftests are expected to support setups where /tmp 
> isn't tmp. Please fix your setup instead (or explain why it's very

Thanks for reviewing. I recently implemented TLS support for MPTCP and
have been adding MPTCP test items to the TLS selftests. When running
these in the MPTCP upstream CI (mptcp-upstream-virtme-docker), these
O_TMPFILE unsupported errors occurred.

Following your suggestion, I looked into the mptcp-upstream-virtme-
docker configuration and found that /tmp isn't mounted as tmpfs; it's
just a plain directory. I've opened a PR to address this:

virtme: mount /tmp as overlay for O_TMPFILE support

https://github.com/multipath-tcp/mptcp-upstream-virtme-docker/pull/43

@Matt

This change adds "--overlay-rwdir /tmp" to virtme-run options, ensuring
/tmp gets mounted as an overlay filesystem. It functions correctly,
though I'm not certain it's the ideal solution.

Thanks,
-Geliang

> crucial that you don't). The upstream CI runs all the selftests in
> VMs and they are working just fine.

      reply	other threads:[~2026-01-19  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  9:02 [PATCH net-next v2] selftests: tls: use mkstemp instead of open(O_TMPFILE) Geliang Tang
2026-01-16  2:49 ` Jakub Kicinski
2026-01-19  6:16   ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66b44ded1d5174131e90fae85b296ef89a53ab24.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=shuah@kernel.org \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox