From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net v2] net: enable interface alias removal via rtnl
Date: Wed, 11 Oct 2017 08:13:45 -0600
Message-ID: <66bbef72-90fb-7142-2070-07dc0c2b0ca9@gmail.com>
References: <1cccbbaa-455b-66e0-a447-7f7e3b3bb375@gmail.com>
 <20171010124138.27342-1-nicolas.dichtel@6wind.com>
 <c81359e7-feb8-475e-69d7-3eacc3406caf@gmail.com>
 <8b334f53-235b-42d2-ba68-4e63c54c498c@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org, oliver@hartkopp.net,
        Stephen Hemminger <stephen@networkplumber.org>
To: nicolas.dichtel@6wind.com, davem@davemloft.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f65.google.com ([74.125.83.65]:34731 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752547AbdJKONm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 11 Oct 2017 10:13:42 -0400
Received: by mail-pg0-f65.google.com with SMTP id u27so2223960pgn.1
        for <netdev@vger.kernel.org>; Wed, 11 Oct 2017 07:13:42 -0700 (PDT)
In-Reply-To: <8b334f53-235b-42d2-ba68-4e63c54c498c@6wind.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/11/17 6:29 AM, Nicolas Dichtel wrote:
> Le 10/10/2017 à 16:50, David Ahern a écrit :
>> On 10/10/17 6:41 AM, Nicolas Dichtel wrote:
>>> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
>>> the attribute is 1 ("\0"). However, to remove an alias, the attribute
>>> length must be 0 (see dev_set_alias()).
>>>
>>> Let's define the type to NLA_BINARY, so that the alias can be removed.
>>
>> not to be pedantic, but we need to be clear that the type is changed
>> only for policy validation.
> With the comment in the code, it is clear, isn't it?

Code comment was fine; commit log -- line referenced above -- is open
for interpretation.