From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes Date: Wed, 10 Oct 2018 16:23:10 -0700 Message-ID: <66c7abb0-cae8-79d9-6c7a-8dcf6732810a@gmail.com> References: <20181009224924.30151-1-f.fainelli@gmail.com> <28926712-da72-7188-e219-152dddec9330@gmail.com> <20181010160949.3cdc4fbc@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev@vger.kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, stable@vger.kernel.org, edumazet@google.com To: Stephen Hemminger Return-path: Received: from mail-ed1-f66.google.com ([209.85.208.66]:44875 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbeJKGrq (ORCPT ); Thu, 11 Oct 2018 02:47:46 -0400 In-Reply-To: <20181010160949.3cdc4fbc@xeon-e3> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/10/2018 04:18 PM, Stephen Hemminger wrote: > On Tue, 9 Oct 2018 21:15:04 -0700 > Florian Fainelli wrote: > >>> >>> Strange, I do not see "ip: use rb trees for IP frag queue." in this list ? >> >> And it was not in Stephen's backport to 4.14 either, wait, looks like it >> was somehow squashed into "net: sk_buff rbnode reorg". Stephen, was >> there a reason for that? >> >> Let me go back and add bffa72cf7f9df842f0016ba03586039296b4caaf as well >> as eeea10b83a139451130df1594f26710c8fa390c8 to the rebase todo and see >> how things go from there. >> >> Thanks for taking a look. > > I don't remember, spent time doing cherry-pick and fixups. Maybe the reorg > commit got squashed as part of one rebase. > No worries, I ended dropping these two commits because they would have required cherry-picking "udp: copy skb->truesize in the first cache line" which did not seem appropriate. I would appreciate if you could take a look at v2 and confirm this does look good, in particular the struct sk_buff layout. Thanks! -- Florian