From: Florian Fainelli <f.fainelli@gmail.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH net-next 3/3] net: dsa: remove dsa_port_phylink_validate()
Date: Mon, 9 Oct 2023 13:35:58 -0700 [thread overview]
Message-ID: <66dbb4e5-39bc-4b61-b80e-483516b3beae@gmail.com> (raw)
In-Reply-To: <E1qpng3-009Ncs-EC@rmk-PC.armlinux.org.uk>
On 10/9/23 03:39, Russell King (Oracle) wrote:
> As all drivers now provide phylink capabilities (including MAC), the
> if() condition in dsa_port_phylink_validate() will always be true. We
> will always use the generic validator, which phylink will call itself
> if the .validate method isn't populated. Thus, there is now no need to
> implement the .validate method, so this implementation can be removed.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2023-10-09 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:56 [PATCH net-next 0/3] net: dsa: remove validate method Russell King (Oracle)
2023-10-09 10:39 ` [PATCH net-next 1/3] net: dsa: vsc73xx: add phylink capabilities Russell King (Oracle)
2023-10-09 13:04 ` Linus Walleij
2023-10-09 20:36 ` Florian Fainelli
2023-10-09 10:39 ` [PATCH net-next 2/3] net: dsa: dsa_loop: " Russell King (Oracle)
2023-10-09 20:35 ` Florian Fainelli
2023-10-09 10:39 ` [PATCH net-next 3/3] net: dsa: remove dsa_port_phylink_validate() Russell King (Oracle)
2023-10-09 20:35 ` Florian Fainelli [this message]
2023-10-11 9:10 ` [PATCH net-next 0/3] net: dsa: remove validate method patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66dbb4e5-39bc-4b61-b80e-483516b3beae@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).