From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A2FC2BCA1 for ; Fri, 7 Jun 2019 12:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2281920665 for ; Fri, 7 Jun 2019 12:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbfFGMSr (ORCPT ); Fri, 7 Jun 2019 08:18:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48154 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727693AbfFGMSq (ORCPT ); Fri, 7 Jun 2019 08:18:46 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA55E44BC6; Fri, 7 Jun 2019 12:18:40 +0000 (UTC) Received: from ovpn-204-179.brq.redhat.com (ovpn-204-179.brq.redhat.com [10.40.204.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 666DE7A503; Fri, 7 Jun 2019 12:18:34 +0000 (UTC) Message-ID: <66ee49271b9ecc89cd2ee7b9fbffd298ae219d14.camel@redhat.com> Subject: Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc From: Davide Caratti To: Lucas Bates , netdev@vger.kernel.org Cc: nicolas.dichtel@6wind.com, davem@davemloft.net, jhs@mojatatu.com, kernel@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, mleitner@redhat.com, vladbu@mellanox.com, Hangbin Liu In-Reply-To: <1559768882-12628-1-git-send-email-lucasb@mojatatu.com> References: <1559768882-12628-1-git-send-email-lucasb@mojatatu.com> Organization: red hat Content-Type: text/plain; charset="UTF-8" Date: Fri, 07 Jun 2019 14:18:33 +0200 Mime-Version: 1.0 User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 07 Jun 2019 12:18:46 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2019-06-05 at 17:08 -0400, Lucas Bates wrote: > Apologies for the delay in getting this out. I've been busy > with other things and this change was a little trickier than > I expected. > > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcases, > and will automatically load any plugin that isn't already > enabled when said plugin is required by even one testcase. > > Additionally, the -n option for the nsPlugin is deprecated > so the default action is to make use of the namespaces. > Instead, we introduce -N to not use them, but still create > the veth pair. > > Comments welcome! > --- hello Lucas, thanks for the patch, I tested it and verified it successfully on some items belonging to the 'filter' category. >From what I see, it is a fix for the reported problem (e.g. tests failing because of 'nsPlugin' uninstalled). And, I want to followup fixing the bpf.json in tc-actions, so that # ./tdc.py -l -c bpf | grep eBPF e939: (actions, bpf) Add eBPF action with valid object-file 282d: (actions, bpf) Add eBPF action with invalid object-file require the buildebpfPlugin (unless anybody disagrees, I will also revert the meaning of '-B' also, like you did for '-n') few comments after a preliminary test: 1) the patch still does not cover the two categories that use $DEV2 (i.e. flower and concurrency still fail in my environment) 2) I've been reported, and reproduced with latest fedora, a problem in nsPlugin.py. All tests in the 'filter' category still fail, unless I do # sed -i "s#ip#/sbin/ip#g" nsPlugin.py otherwise, the 'prepare' stage fails: # ./tdc.py -e 5339 -- ns/SubPlugin.__init__ Test 5339: Del entire fw filter -----> prepare stage *** Could not execute: "$TC qdisc add dev $DEV1 ingress" -----> prepare stage *** Error message: "/bin/sh: ip: command not found " returncode 127; expected [0] -----> prepare stage *** Aborting test run. (maybe we should use a variable for that, instead of hardcoded command name, like we do for $TC ?) -- davide