Netdev List
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
	 "David S . Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>,
	 Jeffrey Ji <jeffreyji@google.com>,
	 netdev@vger.kernel.org,  eric.dumazet@gmail.com,
	 Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD_HORIZON device attribute
Date: Mon, 30 Sep 2024 14:36:50 -0400	[thread overview]
Message-ID: <66faefc2d2802_18b995294fe@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20240930152304.472767-2-edumazet@google.com>

Eric Dumazet wrote:
> Some network devices have the ability to offload EDT (Earliest
> Departure Time) which is the model used for TCP pacing and FQ
> packet scheduler.
> 
> Some of them implement the timing wheel mechanism described in
> https://saeed.github.io/files/carousel-sigcomm17.pdf
> with an associated 'timing wheel horizon'.
> 
> This patch adds dev->max_pacing_offload_horizon expressing
> this timing wheel horizon in nsec units.
> 
> This is a read-only attribute.
> 
> Unless a driver sets it, dev->max_pacing_offload_horizon
> is zero.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

> @@ -2030,6 +2034,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
>  	[IFLA_ALLMULTI]		= { .type = NLA_REJECT },
>  	[IFLA_GSO_IPV4_MAX_SIZE]	= { .type = NLA_U32 },
>  	[IFLA_GRO_IPV4_MAX_SIZE]	= { .type = NLA_U32 },
> +	[IFLA_MAX_PACING_OFFLOAD_HORIZON]= { .type = NLA_REJECT },

nit: checkpatch does not like the lack of whitespace before assignment
in such C99 designated initializers. Probably just stylistic.


  reply	other threads:[~2024-09-30 18:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 15:23 [PATCH net-next 0/2] net: prepare pacing offload support Eric Dumazet
2024-09-30 15:23 ` [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD_HORIZON device attribute Eric Dumazet
2024-09-30 18:36   ` Willem de Bruijn [this message]
2024-10-02 13:47   ` Jakub Kicinski
2024-10-02 14:06     ` Eric Dumazet
2024-09-30 15:23 ` [PATCH net-next 2/2] net_sched: sch_fq: add the ability to offload pacing Eric Dumazet
2024-09-30 17:33   ` Willem de Bruijn
2024-09-30 17:55     ` Eric Dumazet
2024-09-30 18:17       ` Willem de Bruijn
2024-09-30 18:38   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66faefc2d2802_18b995294fe@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jeffreyji@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox