netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>,
	 Jonathan Corbet <corbet@lwn.net>,
	 Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	 Jason Wang <jasowang@redhat.com>,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 "Michael S. Tsirkin" <mst@redhat.com>,
	 Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	 Shuah Khan <shuah@kernel.org>,
	 linux-doc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 netdev@vger.kernel.org,  kvm@vger.kernel.org,
	 virtualization@lists.linux-foundation.org,
	 linux-kselftest@vger.kernel.org,
	 Yuri Benditovich <yuri.benditovich@daynix.com>,
	 Andrew Melnychenko <andrew@daynix.com>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	 gur.stavi@huawei.com,  Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PATCH RFC v5 06/10] tun: Introduce virtio-net hash reporting feature
Date: Wed, 09 Oct 2024 09:57:25 -0400	[thread overview]
Message-ID: <67068bc5283a3_1cca3129482@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20241008-rss-v5-6-f3cf68df005d@daynix.com>

Akihiko Odaki wrote:
> Allow the guest to reuse the hash value to make receive steering
> consistent between the host and guest, and to save hash computation.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  Documentation/networking/tuntap.rst |   7 +++
>  drivers/net/Kconfig                 |   1 +
>  drivers/net/tap.c                   |  45 ++++++++++++++--
>  drivers/net/tun.c                   |  46 ++++++++++++----
>  drivers/net/tun_vnet.h              | 102 +++++++++++++++++++++++++++++++-----
>  include/linux/if_tap.h              |   2 +
>  include/uapi/linux/if_tun.h         |  48 +++++++++++++++++
>  7 files changed, 223 insertions(+), 28 deletions(-)
> 
> diff --git a/Documentation/networking/tuntap.rst b/Documentation/networking/tuntap.rst
> index 4d7087f727be..86b4ae8caa8a 100644
> --- a/Documentation/networking/tuntap.rst
> +++ b/Documentation/networking/tuntap.rst
> @@ -206,6 +206,13 @@ enable is true we enable it, otherwise we disable it::
>        return ioctl(fd, TUNSETQUEUE, (void *)&ifr);
>    }
>  
> +3.4 Reference
> +-------------
> +
> +``linux/if_tun.h`` defines the interface described below:
> +
> +.. kernel-doc:: include/uapi/linux/if_tun.h
> +
>  Universal TUN/TAP device driver Frequently Asked Question
>  =========================================================
>  
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 9920b3a68ed1..e2a7bd703550 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -395,6 +395,7 @@ config TUN
>  	tristate "Universal TUN/TAP device driver support"
>  	depends on INET
>  	select CRC32
> +	select SKB_EXTENSIONS
>  	help
>  	  TUN/TAP provides packet reception and transmission for user space
>  	  programs.  It can be viewed as a simple Point-to-Point or Ethernet
> diff --git a/drivers/net/tap.c b/drivers/net/tap.c
> index 9a34ceed0c2c..5e2fbe63ca47 100644

Merge the earlier tiny patch 2 into this one.

  parent reply	other threads:[~2024-10-09 13:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  6:54 [PATCH RFC v5 00/10] tun: Introduce virtio-net hashing feature Akihiko Odaki
2024-10-08  6:54 ` [PATCH RFC v5 01/10] virtio_net: Add functions for hashing Akihiko Odaki
2024-10-09 13:51   ` Willem de Bruijn
2024-10-12 10:42     ` Akihiko Odaki
2024-10-12 17:40       ` Willem de Bruijn
2024-10-08  6:54 ` [PATCH RFC v5 02/10] skbuff: Introduce SKB_EXT_TUN_VNET_HASH Akihiko Odaki
2024-10-08  6:54 ` [PATCH RFC v5 03/10] net: flow_dissector: Export flow_keys_dissector_symmetric Akihiko Odaki
2024-10-08  6:54 ` [PATCH RFC v5 04/10] tun: Unify vnet implementation Akihiko Odaki
2024-10-09 13:55   ` Willem de Bruijn
2024-10-12 10:57     ` Akihiko Odaki
2024-10-12 17:43       ` Willem de Bruijn
2024-10-08  6:54 ` [PATCH RFC v5 05/10] tun: Pad virtio header with zero Akihiko Odaki
2024-10-09  7:44   ` Jason Wang
2024-10-08  6:54 ` [PATCH RFC v5 06/10] tun: Introduce virtio-net hash reporting feature Akihiko Odaki
2024-10-09  8:05   ` Jason Wang
2024-10-12 10:13     ` Akihiko Odaki
2024-10-09 13:57   ` Willem de Bruijn [this message]
2024-10-08  6:54 ` [PATCH RFC v5 07/10] tun: Introduce virtio-net RSS Akihiko Odaki
2024-10-09  8:14   ` Jason Wang
2024-10-12 10:29     ` Akihiko Odaki
2024-10-18  8:15       ` Jason Wang
2024-10-08  6:54 ` [PATCH RFC v5 08/10] selftest: tun: Test vnet ioctls without device Akihiko Odaki
2024-10-08  6:54 ` [PATCH RFC v5 09/10] selftest: tun: Add tests for virtio-net hashing Akihiko Odaki
2024-10-08  6:54 ` [PATCH RFC v5 10/10] vhost/net: Support VIRTIO_NET_F_HASH_REPORT Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67068bc5283a3_1cca3129482@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=andrew@daynix.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gur.stavi@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).