From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Stanislav Fomichev <stfomichev@gmail.com>,
Muyang Tian <tianmuyang@huawei.com>
Cc: bpf@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, yanan@huawei.com,
xiesongyang@huawei.com, wuchangye@huawei.com,
liuxin350@huawei.com, zhangmingyi5@huawei.com,
liwei883@huawei.com, willemb@google.com
Subject: Re: [PATCH bpf-next v2 0/3] XDP metadata: Rx checksum/GSO hint; Tx GSO offload
Date: Sun, 20 Oct 2024 16:51:00 -0400 [thread overview]
Message-ID: <67156d3447444_14e182944b@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <ZxKPXdYjwPnpq95V@mini-arch>
Stanislav Fomichev wrote:
> On 10/18, Muyang Tian wrote:
> > This series introduce XDP metadata functionality, including Rx checksum/GSO hint
> > and Tx GSO offload. This is aimed to transfer control fields when processing jumbo
> > frames between VMs.
>
> Ideally, the series should also have the implementation of these hints
> for a couple of devices and appropriate selftest updates to exercise
> them.
+1
> For GSO, CC Willem going forward (I don't think I understand why
> we want to have gso_type in the TX hint; something like header_len
> seems like a better fit).
GSO on Tx makes sense. To be able to program hardware USO, say.
GSO on Rx is less obvious. Is this for HW-GRO? In general, some usage
context will be helpful.
Two implementation questions:
- why define an XDP specific type for checksum types, but reuse the
netdev type for gso_type?
- why u32 gso_type, when it is a u8 in skb_shared_info?
> Please also don't post v3 yet and allow at least a week for the initial
> reviewers to catch up..
next prev parent reply other threads:[~2024-10-20 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 9:14 [PATCH bpf-next v2 0/3] XDP metadata: Rx checksum/GSO hint; Tx GSO offload Muyang Tian
2024-10-18 9:15 ` [PATCH bpf-next v2 1/3] xdp: Add Rx checksum hint Muyang Tian
2024-10-18 9:15 ` [PATCH bpf-next v2 2/3] xdp: Add Rx GSO hint Muyang Tian
2024-10-18 9:15 ` [PATCH bpf-next v2 3/3] xsk: Add Tx GSO type and size offload support Muyang Tian
2024-10-18 16:39 ` [PATCH bpf-next v2 0/3] XDP metadata: Rx checksum/GSO hint; Tx GSO offload Stanislav Fomichev
2024-10-20 20:51 ` Willem de Bruijn [this message]
2024-10-21 12:04 ` Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67156d3447444_14e182944b@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxin350@huawei.com \
--cc=liwei883@huawei.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
--cc=tianmuyang@huawei.com \
--cc=willemb@google.com \
--cc=wuchangye@huawei.com \
--cc=xiesongyang@huawei.com \
--cc=yanan@huawei.com \
--cc=zhangmingyi5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox