From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, andriy.shevchenko@linux.intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/7] enc28j60: Use device_get_mac_address()
Date: Fri, 01 Mar 2019 21:56:53 -0800 [thread overview]
Message-ID: <6730380b989aaaa83aaaa06bd4e22bcd11171d75.camel@perches.com> (raw)
In-Reply-To: <20190301.214656.1038989694037240046.davem@davemloft.net>
On Fri, 2019-03-01 at 21:46 -0800, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Thu, 28 Feb 2019 23:34:29 +0300
>
> > @@ -1554,7 +1554,7 @@ static int enc28j60_probe(struct spi_device *spi)
> > {
> > struct net_device *dev;
> > struct enc28j60_net *priv;
> > - const void *macaddr;
> > + unsigned char macaddr[ETH_ALEN];
> > int ret = 0;
>
> Preserve the reverse christmas tree here please.
There is no reverse christmas tree here.
prev parent reply other threads:[~2019-03-02 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:34 [PATCH v1 1/7] enc28j60: Use device_get_mac_address() Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 2/7] enc28j60: Remove duplicate messaging Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 3/7] enc28j60: Replace dev_*(&netdev->dev, ...) with netdev_*() Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 4/7] enc28j60: Drop driver name duplication from messages Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 5/7] enc28j60: Switch to use module_spi_driver() macro Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 6/7] enc28j60: Remove linux/init.h Andy Shevchenko
2019-02-28 20:34 ` [PATCH v1 7/7] enc28j60: Convert to use SPDX identifier Andy Shevchenko
2019-03-02 5:46 ` [PATCH v1 1/7] enc28j60: Use device_get_mac_address() David Miller
2019-03-02 5:56 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6730380b989aaaa83aaaa06bd4e22bcd11171d75.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).