From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake)
 qdisc
Date: Fri, 27 Apr 2018 06:44:11 -0700
Message-ID: <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com>
References: <20180427121706.23273-1-toke@toke.dk>
 <efb401ac-bc79-cbc5-cd03-120803b65b4d@gmail.com> <87in8c4vn7.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f43.google.com ([74.125.83.43]:40732 "EHLO
        mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932754AbeD0NoN (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 27 Apr 2018 09:44:13 -0400
Received: by mail-pg0-f43.google.com with SMTP id l2-v6so1615246pgc.7
        for <netdev@vger.kernel.org>; Fri, 27 Apr 2018 06:44:12 -0700 (PDT)
In-Reply-To: <87in8c4vn7.fsf@toke.dk>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 04/27/2018 06:38 AM, Toke Høiland-Jørgensen wrote:
> 
> Ah, right. Will fix.
> 
> Is it safe to dereference the iph pointer before calling
> pskb_may_pull()?

No, please take a look at ip_rcv() for a typical use case.