From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0624E1BBBDC; Thu, 21 Nov 2024 23:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732232053; cv=none; b=LWA/lyuJqHbUSEw6r2liY4uIMGntcaoW0W3uL7KiNuslOvt9J+9hB7WjM0/+DByy6JT0FZ2554iMcBW3gY33aDBOrklHVYRgYakJ5MLnmmItKb1gWLOQA0t4kNuCMAegggyJXotUYKiHE8RtGiKvqslp01Cic0zo3zzWG+pf/Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732232053; c=relaxed/simple; bh=qdLMV8zGkvT/QtA/r+qtvK3bWoQ/glpHCnqXfNcoVvA=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=dVZ2WMWTgwcN0+Uul8QlKjhjywvkWtdnR4lEKf5/BpWJ3mr9gxTDGv1d1jODjppf1wYvXUNq5yXEdifWySDmtqB3DzHZh9WdHZ5gAJbBHx24IBCcaUr/WubSqtYFjDlomdOy3qVOhKpRFO7/X9uP/WWE2W/bJksfrPr09T99gQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RzRynrtC; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RzRynrtC" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2ea78d164b3so1291085a91.2; Thu, 21 Nov 2024 15:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732232051; x=1732836851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sUac66YlDe4DsE8EEWH0kHICeDsnP4YHiVPJ73sgToc=; b=RzRynrtCHnsw7N9bgr/dp5/VkGRt8lKh5NvACjzDna3gVXwP5c4dYXMmiANzcQDptX YsQ9BsMTAJXv7FNZWKldi8/rrv2itdRa48iU7uJjyaO8TS5iGDgkNWoByzGLtNfAbvZc OixTg5UsKdfWe6zyBZGt77uIIrqfg2UMeM/Ss/t/0s/wLTI8ECnW13nBYFNsYW3lyJ2Y oFTvRYEVacRF9ZXKpeveZ+bqR2d+gDCyY4R3hGEeUalA/D/czIgUrVpfyyrtXMUeml65 ol/2rzp4pS/u0KOKtcNkvhMtsPrptQ+vRG/+FTWbcVgbiuGRUtOipi8Lp+NVDIdVSzyn nq/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732232051; x=1732836851; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sUac66YlDe4DsE8EEWH0kHICeDsnP4YHiVPJ73sgToc=; b=e6ZBpVwCzowMQqvdQoVnkVILtWX649zZ9whGFZLxUMmyVpUisdiJnxb12ysI/HCVrj 3xjmH+uXgFWVGRYk7PDglR8QwVdpbIMhvXSbENNBTQeSE3bhIvJqj/2Bmt7SyYBSsqFQ vtkv8df74w4wTuH+ENkzSKdrsQ6Ex2sQmH9FyWEIPzBRylpwvnyDpsojfK+YSACqfIZg u5bCdWK1EPlyiee9DPd1bMxmjj2gKMBquCynp24UMZSz+gXw+kmDkG13DPB9MZPUxDnB Z8CKmYgX934jDlsdfpCLPXIJVZjNOCwpI7Bp9wCae8B22L4ciMTLu/FpbdZYYLsyMWhe fFYw== X-Forwarded-Encrypted: i=1; AJvYcCUTGWEveDWIe51UqMqu0KOmjP2wUc+y2rqxRH4laoQ2Hb5cqr6B/xJSRxBUOClTcIcgAZLMnYiK@vger.kernel.org, AJvYcCW+iBcFrL5bAN/RT6MxgyqTvrZf73tW1jmpmLA+EJLXbuGQs64p4mH8XMJMwi5e3dHBG2k=@vger.kernel.org, AJvYcCXgTKAOEjc6/gVZgg7RLY7NFig2VR2mdv7wmUiNWeh/Fzun146j36c3Jy4JQcddbDw2D0+jdEWoW6N5L/c6lyoL@vger.kernel.org X-Gm-Message-State: AOJu0YzkZMB/n7prZjh7SydNj8C2ID77FJsOTTSYObVCW8E/M8FKODLK G5JL8vQJSscyFdw0g3aot7qr23qrm+qbI3FeW9065bNrmQwG7X5d X-Gm-Gg: ASbGncu2y9bmwEEs1BLhfDAbfZymCjhYypFik3FyL4tj5s3wSawiV4MngWmJ2K9j4SI DqCr2H+6p8P8Q1uNChHcNOTFYq4F1TXa9q+IidYJp4/nK9fCTbalmBpMGc9NCDtYgd9N3IypIlh wuwtmCFSV91OGiqZ25jSecO18Wsitrwm0zIIyVXFBwOnX1mILPKPU2JWocO9nhvAkuvmJgXvu8H BMndc2NJNU5Npls5Sk30F41uUAF8/aO7SEvrxVBYkAoWV6JcC8= X-Google-Smtp-Source: AGHT+IEkytm/0Te1RFpMjsSqr2S2XW50TP0rS/sdJu/aDq05wk1ZduEAst0IkX1ljEDoqogYVHMagg== X-Received: by 2002:a17:90b:4a47:b0:2ea:3d61:1846 with SMTP id 98e67ed59e1d1-2eb0e86b6a4mr738871a91.26.1732232051137; Thu, 21 Nov 2024 15:34:11 -0800 (PST) Received: from localhost ([98.97.39.253]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fbcc42262esm265604a12.86.2024.11.21.15.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 15:34:10 -0800 (PST) Date: Thu, 21 Nov 2024 15:34:09 -0800 From: John Fastabend To: Stefano Garzarella , John Fastabend Cc: Michal Luczaj , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Bobby Eshleman , "Michael S. Tsirkin" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Message-ID: <673fc371c9de1_11182089c@john.notmuch> In-Reply-To: References: <20241118-vsock-bpf-poll-close-v1-0-f1b9669cacdc@rbox.co> <673ed7b929dbe_157a2089e@john.notmuch> Subject: Re: [PATCH bpf 0/4] bpf, vsock: Fix poll() and close() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Stefano Garzarella wrote: > On Wed, Nov 20, 2024 at 10:48:25PM -0800, John Fastabend wrote: > >Michal Luczaj wrote: > >> Two small fixes for vsock: poll() missing a queue check, and close() not > >> invoking sockmap cleanup. > >> > >> Signed-off-by: Michal Luczaj > >> --- > >> Michal Luczaj (4): > >> bpf, vsock: Fix poll() missing a queue > >> selftest/bpf: Add test for af_vsock poll() > >> bpf, vsock: Invoke proto::close on close() > >> selftest/bpf: Add test for vsock removal from sockmap on close() > >> > >> net/vmw_vsock/af_vsock.c | 70 ++++++++++++-------- > >> .../selftests/bpf/prog_tests/sockmap_basic.c | 77 ++++++++++++++++++++++ > >> 2 files changed, 120 insertions(+), 27 deletions(-) > >> --- > >> base-commit: 6c4139b0f19b7397286897caee379f8321e78272 > >> change-id: 20241118-vsock-bpf-poll-close-64f432e682ec > >> > >> Best regards, > >> -- > >> Michal Luczaj > >> > > > >LGTM, would be nice to get an ack from someone on the vsock side > >though. > > Sorry, is at the top of my list but other urgent things have come up. > > I will review it by today. Thanks a lot Stefano much appreciated! I was also slow to review as I was travelling and on PTO. > > Stefano > > > > >Acked-by: John Fastabend > > >