From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH 1/5] phylib: don't return NULL from get_phy_device()
Date: Thu, 28 Apr 2016 00:07:22 +0200 [thread overview]
Message-ID: <6742276.xmgnFOC4z8@wuerfel> (raw)
In-Reply-To: <57213371.1020905@gmail.com>
On Wednesday 27 April 2016 14:47:29 Florian Fainelli wrote:
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 499003ee8055..94a27b028dd8 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -333,7 +333,7 @@ int __mdiobus_register(struct mii_bus *bus, struct
> module *owner)
> struct phy_device *phydev;
>
> phydev = mdiobus_scan(bus, i);
> - if (IS_ERR(phydev)) {
> + if (IS_ERR(phydev) && PTR_ERR(phydev) != -ENODEV) {
> err = PTR_ERR(phydev);
> goto error;
> }
>
>
I think that is an improvement over the original code, and better than
reverting the series. Out of the three callers of mdiobus_scan, I already
commented on drivers/net/ethernet/marvell/pxa168_eth.c being wrong to
start with, and drivers/net/ethernet/cadence/macb.c seems to require
the same fix that you did here for mdio_bus.c
Arnd
next prev parent reply other threads:[~2016-04-27 22:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 17:23 [PATCH 0/5] Don't return NULL from get_phy_device() anymore Sergei Shtylyov
2016-04-24 17:25 ` [PATCH 1/5] phylib: don't return NULL from get_phy_device() Sergei Shtylyov
2016-04-25 19:45 ` Florian Fainelli
[not found] ` <874mamzw5q.fsf@ketchup.mtl.sfl>
2016-04-27 19:49 ` Andrew Lunn
2016-04-27 20:09 ` Sergei Shtylyov
2016-04-27 20:23 ` David Miller
2016-04-27 22:03 ` Arnd Bergmann
2016-04-27 21:47 ` Florian Fainelli
2016-04-27 22:07 ` Arnd Bergmann [this message]
2016-04-27 20:12 ` Sergei Shtylyov
2016-04-27 20:11 ` Florian Fainelli
2016-04-24 17:27 ` [PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:29 ` [PATCH 3/5] fixed_phy: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:30 ` [PATCH 4/5] mdio_bus: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:31 ` [PATCH 5/5] of_mdio: " Sergei Shtylyov
2016-04-24 17:37 ` Sergei Shtylyov
2016-04-25 19:47 ` Florian Fainelli
2016-04-26 19:41 ` [PATCH 0/5] Don't return NULL from get_phy_device() anymore David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6742276.xmgnFOC4z8@wuerfel \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).