From: Ilya Matveychikov <matvejchikov@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH] tcp_input: move out condition check from tcp_data_queue()
Date: Sun, 6 Aug 2017 13:51:17 +0400 [thread overview]
Message-ID: <674DB789-9B28-4A9C-A0BF-D91023CB86F3@gmail.com> (raw)
As tcp_data_queue() function is used just only twice it's better
to move out the first check and wrap it with inline. It saves a
single call in case the condition evaluated as true.
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
net/ipv4/tcp_input.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 2920e0c..141a722 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -4585,16 +4585,12 @@ int tcp_send_rcvq(struct sock *sk, struct msghdr *msg, size_t size)
}
-static void tcp_data_queue(struct sock *sk, struct sk_buff *skb)
+static void __tcp_data_queue(struct sock *sk, struct sk_buff *skb)
{
struct tcp_sock *tp = tcp_sk(sk);
bool fragstolen = false;
int eaten = -1;
- if (TCP_SKB_CB(skb)->seq == TCP_SKB_CB(skb)->end_seq) {
- __kfree_skb(skb);
- return;
- }
skb_dst_drop(skb);
__skb_pull(skb, tcp_hdr(skb)->doff * 4);
@@ -4703,6 +4699,14 @@ static void tcp_data_queue(struct sock *sk, struct sk_buff *skb)
tcp_data_queue_ofo(sk, skb);
}
+static inline void tcp_data_queue(struct sock *sk, struct sk_buff *skb)
+{
+ if (TCP_SKB_CB(skb)->seq == TCP_SKB_CB(skb)->end_seq)
+ __kfree_skb(skb);
+ else
+ __tcp_data_queue(sk, skb);
+}
+
static struct sk_buff *tcp_skb_next(struct sk_buff *skb, struct sk_buff_head *list)
{
if (list)
--
2.7.4
next reply other threads:[~2017-08-06 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 9:51 Ilya Matveychikov [this message]
2017-08-06 17:07 ` [PATCH] tcp_input: move out condition check from tcp_data_queue() Eric Dumazet
2017-08-06 17:57 ` Ilya Matveychikov
2017-08-07 5:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=674DB789-9B28-4A9C-A0BF-D91023CB86F3@gmail.com \
--to=matvejchikov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox