Netdev List
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Anna Nyiri <annaemesenyiri@gmail.com>,  Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org,  fejes@inf.elte.hu,  edumazet@google.com,
	 kuba@kernel.org,  pabeni@redhat.com,  willemb@google.com
Subject: Re: [PATCH net-next v6 3/4] selftests: net: test SO_PRIORITY ancillary data with cmsg_sender
Date: Thu, 12 Dec 2024 11:51:15 -0500	[thread overview]
Message-ID: <675b1483aa913_d785729467@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <CAKm6_RtLzq7MW6Ut0ok_2rOyGqOgVDWr9mbaE-4Ts4Hup_454w@mail.gmail.com>

Anna Nyiri wrote:
> What is the current maximum allowed line length? Because the
> checkpatch script permits up to 100 characters for max_line_length.
> But I received warning on patchwork.kernel.org site:
> 
> WARNING: line length of 86 exceeds 80 columns
> #64: FILE: tools/testing/selftests/net/cmsg_sender.c:121:
> + while ((o = getopt(argc, argv, "46sS:p:P:m:M:n:d:tf:F:c:C:l:L:H:Q:")) != -1) {

You can ignore that in cases where exceeding it makes sense, as it
does here. Up to 100 chars IIRC.

Btw, also please no top posting in kernel mailing lists.

  reply	other threads:[~2024-12-12 16:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 19:13 [PATCH net-next v6 0/4] Add support for SO_PRIORITY cmsg Anna Emese Nyiri
2024-12-10 19:13 ` [PATCH net-next v6 1/4] sock: Introduce sk_set_prio_allowed helper function Anna Emese Nyiri
2024-12-10 19:13 ` [PATCH net-next v6 2/4] sock: support SO_PRIORITY cmsg Anna Emese Nyiri
2024-12-10 19:13 ` [PATCH net-next v6 3/4] selftests: net: test SO_PRIORITY ancillary data with cmsg_sender Anna Emese Nyiri
2024-12-11  0:56   ` Willem de Bruijn
2024-12-11 10:01   ` Ido Schimmel
2024-12-12 16:35     ` Anna Nyiri
2024-12-12 16:51       ` Willem de Bruijn [this message]
2024-12-10 19:13 ` [PATCH net-next v6 4/4] sock: Introduce SO_RCVPRIORITY socket option Anna Emese Nyiri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=675b1483aa913_d785729467@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=annaemesenyiri@gmail.com \
    --cc=edumazet@google.com \
    --cc=fejes@inf.elte.hu \
    --cc=idosch@idosch.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox