From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jeroen de Borst <jeroendb@google.com>, Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com,
pkaligineedi@google.com, shailend@google.com, hawk@kernel.org,
john.fastabend@gmail.com, willemb@google.com,
bpf@vger.kernel.org
Subject: Re: [PATCH net] eth: gve: use appropriate helper to set xdp_features
Date: Tue, 07 Jan 2025 04:30:19 -0500 [thread overview]
Message-ID: <677cf42b9e361_23f4742946a@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <CAErkTsR0Av6sFnabSSJ7TNtix8Y_QLX+xb6vShvx3P0GyV3w9A@mail.gmail.com>
Jeroen de Borst wrote:
> Reviewed-By: Jeroen de Borst <jeroendb@google.com>
>
>
>
> On Mon, Jan 6, 2025 at 10:02 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > Commit f85949f98206 ("xdp: add xdp_set_features_flag utility routine")
> > added routines to inform the core about XDP flag changes.
> > GVE support was added around the same time and missed using them.
> >
> > GVE only changes the flags on error recover or resume.
> > Presumably the flags may change during resume if VM migrated.
> > User would not get the notification and upper devices would
> > not get a chance to recalculate their flags.
> >
> > Fixes: 75eaae158b1b ("gve: Add XDP DROP and TX support for GQI-QPL format")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Thanks!
> > ---
> > CC: jeroendb@google.com
Reminder: please don't top post
next prev parent reply other threads:[~2025-01-07 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 18:02 [PATCH net] eth: gve: use appropriate helper to set xdp_features Jakub Kicinski
2025-01-06 23:25 ` Jeroen de Borst
2025-01-07 9:30 ` Willem de Bruijn [this message]
2025-01-08 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=677cf42b9e361_23f4742946a@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jeroendb@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox