netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandra Winter <wintera@linux.ibm.com>
To: Johannes Berg <johannes@sipsolutions.net>, netdev@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH net-next] net: drop special comment style
Date: Wed, 17 Jul 2024 11:22:00 +0200	[thread overview]
Message-ID: <678590f7-a550-42b7-b8a0-a40eb3313030@linux.ibm.com> (raw)
In-Reply-To: <20240716134822.028c84bbd92f.Ic187fbc5ba452463ef28feebbd5c18668adb0fec@changeid>



On 16.07.24 22:48, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> As we just discussed (in the room at netdevconf), drop the
> requirement for special comment style for netdev.
> 
> For checkpatch, the general check accepts both right now,
> so simply drop the special request there as well.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>  Documentation/process/maintainer-netdev.rst | 17 -----------------
>  scripts/checkpatch.pl                       | 10 ----------
>  2 files changed, 27 deletions(-)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index 5e1fcfad1c4c..5a411c52b466 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst


I guess you should also remove the section in 

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 7e768c65aa92..3ccda9f42cfa 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -629,18 +629,6 @@ The preferred style for long (multi-line) comments is:
         * with beginning and ending almost-blank lines.
         */

-For files in net/ and drivers/net/ the preferred style for long (multi-line)
-comments is a little different.
-
-.. code-block:: c
-
-       /* The preferred comment style for files in net/ and drivers/net
-        * looks like this.
-        *
-        * It is nearly the same as the generally preferred comment style,
-        * but there is no initial almost-blank line.
-        */
-
 It's also important to comment data, whether they are basic types or derived
 types.  To this end, use just one data declaration per line (no commas for
 multiple data declarations).  This leaves you room for a small comment on each


  parent reply	other threads:[~2024-07-17  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 20:48 [PATCH net-next] net: drop special comment style Johannes Berg
2024-07-17  2:35 ` Stephen Hemminger
2024-07-17  9:22 ` Alexandra Winter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-07-18 18:07 Johannes Berg
2024-07-19  9:38 ` Jiri Pirko
2024-07-23  9:51 ` Paolo Abeni
2024-07-23  9:55   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=678590f7-a550-42b7-b8a0-a40eb3313030@linux.ibm.com \
    --to=wintera@linux.ibm.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).