Re: [PATCH v9 12/27] sfc: set cxl media ready

Jonathan Cameron
2025-01-02T14:55:46Z

On Mon, 30 Dec 2024 21:44:30 +0000
<alejandro.lucero-palau@amd.com> wrote:

> From: Alejandro Lucero <alucerop@amd.com>
>
> Use cxl api accessor for explicitly set media ready as hardware design
> implies it is ready and there is no device register for stating so.
>
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>
> Acked-by: Edward Cree <ecree.xilinx@gmail.com>
FWIW

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/net/ethernet/sfc/efx_cxl.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 2031f08ee689..911f29b91bd3 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -91,6 +91,11 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
> goto err_resource_set;
> }
>
> + /* We do not have the register about media status. Hardware design
> + * implies it is ready.
> + */
> + cxl_set_media_ready(cxl->cxlds);
> +
> probe_data->cxl = cxl;
>
> return 0;