Re: [PATCH v9 13/27] cxl: prepare memdev creation for type2

Alejandro Lucero Palau
2025-01-03T07:24:56Z

On 1/2/25 15:01, Jonathan Cameron wrote:
> On Mon, 30 Dec 2024 21:44:31 +0000
> <alejandro.lucero-palau@amd.com> wrote:
>
>> From: Alejandro Lucero <alucerop@amd.com>
>>
>> Current cxl core is relying on a CXL_DEVTYPE_CLASSMEM type device when
>> creating a memdev leading to problems when obtaining cxl_memdev_state
>> references from a CXL_DEVTYPE_DEVMEM type. This last device type is
>> managed by a specific vendor driver and does not need same sysfs files
>> since not userspace intervention is expected.
>>
>> Create a new cxl_mem device type with no attributes for Type2.
>>
>> Avoid debugfs files relying on existence of cxl_memdev_state.
> "Avoid debugfs files that rely on existence of cxl_memdev_state."
>
> Currently it means you keep the files but break their reliance
> on that state. So subtly different from what is implemented.

It makes sense.

I'll fix it in v10.

Thanks!

>> Make devm_cxl_add_memdev accesible from a accel driver.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
>