From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
Simon Horman <horms@kernel.org>,
eric.dumazet@gmail.com, Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 4/4] udp: use EXPORT_IPV6_MOD[_GPL]()
Date: Mon, 10 Feb 2025 21:56:26 -0500 [thread overview]
Message-ID: <67aabc5aea2eb_881f329441@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250210082805.465241-5-edumazet@google.com>
Eric Dumazet wrote:
> Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
> to be exported unless CONFIG_IPV6=m
>
> udp_table is no longer used from any modules, and does not
> need to be exported anyway.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Should udp_disconnect be included?
And perhaps udp_encap_needed_key. The only real user is static inline
udp_unexpected_gso, itself only used in core udp code. But not sure if
it would cause build errors.
With those minor asides
Acked-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-02-11 2:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 8:28 [PATCH net-next 0/4] net: add EXPORT_IPV6_MOD() Eric Dumazet
2025-02-10 8:28 ` [PATCH net-next 1/4] net: introduce EXPORT_IPV6_MOD() and EXPORT_IPV6_MOD_GPL() Eric Dumazet
2025-02-10 8:28 ` [PATCH net-next 2/4] inetpeer: use EXPORT_IPV6_MOD[_GPL]() Eric Dumazet
2025-02-10 8:28 ` [PATCH net-next 3/4] tcp: " Eric Dumazet
2025-02-10 8:41 ` Mateusz Polchlopek
2025-02-10 9:08 ` Eric Dumazet
2025-02-10 9:23 ` Mateusz Polchlopek
2025-02-10 9:30 ` Sabrina Dubroca
2025-02-10 9:44 ` Eric Dumazet
2025-02-10 9:56 ` Eric Dumazet
2025-02-10 11:35 ` Sabrina Dubroca
2025-02-10 12:26 ` Eric Dumazet
2025-02-10 12:21 ` kernel test robot
2025-02-10 8:28 ` [PATCH net-next 4/4] udp: " Eric Dumazet
2025-02-11 2:56 ` Willem de Bruijn [this message]
2025-02-11 8:08 ` Eric Dumazet
2025-02-10 9:25 ` [PATCH net-next 0/4] net: add EXPORT_IPV6_MOD() Mateusz Polchlopek
2025-02-10 18:33 ` Willem de Bruijn
2025-02-10 18:46 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67aabc5aea2eb_881f329441@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox