Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

Jakub Kicinski
2025-02-13T04:18:15Z

On Wed, 12 Feb 2025 18:49:38 -0800 Stanislav Fomichev wrote:
> > + if cfg.have_stat_super_count:
> > + ksft_lt(qstat_new['tx-hw-gso-packets'] -
> > + qstat_old['tx-hw-gso-packets'],
> > + 100, comment="Number of LSO super-packets with LSO disabled")
> > + if cfg.have_stat_wire_count:
> > + ksft_lt(qstat_new['tx-hw-gso-wire-packets'] -
> > + qstat_old['tx-hw-gso-wire-packets'],
> > + 1000, comment="Number of LSO wire-packets with LSO disabled")
>
> Why do you expect there to be some noise (100/1000) with the feature
> disabled?

We disable flag by flag. We may be disabling tunnel lso while some
background daemon is sending stuff with normal lso.

Looking at those numbers now, tho, I think I went a bit high.
100 * 64k = 6MB. We should probably set the noise to 10 super, 500 wire.
--
pw-bot: cr