Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

Jakub Kicinski
2025-02-13T17:07:46Z

On Thu, 13 Feb 2025 11:01:33 -0500 Willem de Bruijn wrote:
> Is the special handling of GSO partial needed?
>
> This test is not trying to test that feature.

If I leave partial enabled and disable tx-udp_tnl-segmentation
I still get TSO packets in the driver in the vxlan tests.
Not entirely unreasonable since these are the HW features,
and with partial enabled the HW does not do UDP tunnel-aware
segmentation?

> > +def main() -> None:
> > + with NetDrvEpEnv(__file__, nsim_test=False) as cfg:
> > + cfg.ethnl = EthtoolFamily()
> > + cfg.netnl = NetdevFamily()
> > +
> > + query_nic_features(cfg)
> > +
> > + tun_info = (
> > + # name, ethtool_feature tun:(type, args 4/6 only)
> > + ("", "tx-tcp6-segmentation", None),
>
> tx-tcp6-segmentation implies v6 only? The catch-all is tcp-segmentation-offload.

oops, if only I had an ipv4 network to test on :)