Netdev List
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Marcus Wichelmann <marcus.wichelmann@hetzner-cloud.de>,
	 netdev@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 bpf@vger.kernel.org,  linux-kselftest@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com,  jasowang@redhat.com,
	 andrew+netdev@lunn.ch,  davem@davemloft.net,
	 edumazet@google.com,  kuba@kernel.org,  pabeni@redhat.com,
	 andrii@kernel.org,  eddyz87@gmail.com,  mykolal@fb.com,
	 ast@kernel.org,  daniel@iogearbox.net,  martin.lau@linux.dev,
	 song@kernel.org,  yonghong.song@linux.dev,
	 john.fastabend@gmail.com,  kpsingh@kernel.org,  sdf@fomichev.me,
	 haoluo@google.com,  jolsa@kernel.org,  shuah@kernel.org,
	 hawk@kernel.org
Subject: Re: [PATCH bpf-next v3 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program
Date: Tue, 25 Feb 2025 13:23:34 -0500	[thread overview]
Message-ID: <67be0aa61e400_25ccfc29426@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <efcc6e11-2d3a-489e-80bc-cbc3f72f7afa@hetzner-cloud.de>

Marcus Wichelmann wrote:
> Am 24.02.25 um 16:29 schrieb Marcus Wichelmann:
> > [...]
> > +	/* By default, Linux sends IPv6 multicast listener reports which
> > +	 * interfere with this test. Set the IFF_NOARP flag to ensure
> > +	 * silence on the interface.
> > +	 */
> > +	SYS(close, "ip link set dev " RX_NAME " arp off");
> >   	SYS(close, "ip link set dev " RX_NAME " up");
> 
> Hm, setting the NOARP flag seems to have not been sufficient to fix the flaky
> test:
> https://github.com/kernel-patches/bpf/actions/runs/13507111620/job/37739614229
> 
> I was not able to reproduce it locally or with my own CI runs unfortunately, but
> I'll try something else in the next patch version which should definitely stop
> IPv6 multicast listener report packets from messing with the tests.

You probably want to pass nodad to any ip -6 addr add.

This is a common option you'll find in tools/testing/selftests/net.

RFC 3810 section 5.2.13 says

"
   For stateless autoconfiguration, as defined in [RFC2462], a node is
   required to join several IPv6 multicast groups, in order to perform
   Duplicate Address Detection (DAD).
"

  reply	other threads:[~2025-02-25 18:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 15:29 [PATCH bpf-next v3 0/6] XDP metadata support for tun driver Marcus Wichelmann
2025-02-24 15:29 ` [PATCH bpf-next v3 1/6] net: tun: enable XDP metadata support Marcus Wichelmann
2025-02-26  5:50   ` Jason Wang
2025-02-24 15:29 ` [PATCH bpf-next v3 2/6] net: tun: enable transfer of XDP metadata to skb Marcus Wichelmann
2025-02-25 18:26   ` Willem de Bruijn
2025-02-26  5:59   ` Jason Wang
2025-02-24 15:29 ` [PATCH bpf-next v3 3/6] selftests/bpf: move open_tuntap to network helpers Marcus Wichelmann
2025-02-25 18:24   ` Willem de Bruijn
2025-02-26  6:31   ` Jason Wang
2025-02-24 15:29 ` [PATCH bpf-next v3 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program Marcus Wichelmann
2025-02-24 17:12   ` Stanislav Fomichev
2025-02-26 15:56     ` Marcus Wichelmann
2025-02-25 15:07   ` Marcus Wichelmann
2025-02-25 18:23     ` Willem de Bruijn [this message]
2025-02-26 17:39       ` Marcus Wichelmann
2025-02-25 18:32   ` Willem de Bruijn
2025-02-26 17:14     ` Marcus Wichelmann
2025-02-24 15:29 ` [PATCH bpf-next v3 5/6] selftests/bpf: add test for XDP metadata support in tun driver Marcus Wichelmann
2025-02-24 17:14   ` Stanislav Fomichev
2025-02-26 18:50     ` Marcus Wichelmann
2025-02-26 19:00       ` Stanislav Fomichev
2025-02-26 19:29         ` Marcus Wichelmann
2025-02-24 15:29 ` [PATCH bpf-next v3 6/6] selftests/bpf: fix file descriptor assertion in open_tuntap helper Marcus Wichelmann
2025-02-25 18:24   ` Willem de Bruijn
2025-02-25 14:55 ` [PATCH bpf-next v3 0/6] XDP metadata support for tun driver Willem de Bruijn
2025-02-25 15:03   ` Marcus Wichelmann
2025-02-25 18:14     ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67be0aa61e400_25ccfc29426@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=marcus.wichelmann@hetzner-cloud.de \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox