From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8189BC43381 for ; Tue, 19 Feb 2019 18:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50F1F2147C for ; Tue, 19 Feb 2019 18:30:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZiXa3RUg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727585AbfBSSak (ORCPT ); Tue, 19 Feb 2019 13:30:40 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45670 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726078AbfBSSaj (ORCPT ); Tue, 19 Feb 2019 13:30:39 -0500 Received: by mail-pf1-f196.google.com with SMTP id v21so7613224pfm.12 for ; Tue, 19 Feb 2019 10:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DTHazE9H6L0EdVIEjMX0QICKfE7R7g1rHdPEUbRfSPE=; b=ZiXa3RUgcD4BEUZOM2b/vWqILC2CY7V7irZ5Bu7q8UGzdY1KB7+t/h60fMcNoubwnB 9YvF/VeJaEcmBxbbRbphDiGZEA5rlRyxhc1KOAzdoAhy+2KVGHXZ94DQnEu9+83MYIfG c7sa33UMQSPZ54aT/fvMukuLdcB+58fIWWhS4O0o4uLGL4/vJXPln3M+FumIOk0TbC6e zBypTcLMFJWQ6bYj1XDU080FvBTNyP9Os4XJgq2Vv3ox9WyKPyy7pQSWm84qseW2xrmx Ix9rv7tFvlk8duL+7fzY29Mq4JIaUEo2qxTMRw8LvNa6VVvuJmQkHXLD/77Wb7SMEYPa YuNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DTHazE9H6L0EdVIEjMX0QICKfE7R7g1rHdPEUbRfSPE=; b=QWPxz62DPg78miFe6MhgGNqikJjxcUtsyyljrug4z670xiOEJH/Nx+djXoCWVnCDmW i19wrPhJZTAf3qJcwN5QBQPExN0gzot+7vKqcgJgJukevxL9IZKzdJbuR7hAHmEMLoeX pXcwtFQnnwW0ebeGt9blZLqFWZI5zPY9Wlg+e24LsjQcrKIrLRWKsBC5Q2gNhPmnwPU8 5h6lMJQkJdLb1YSN610zHbyu5mIrGvwrrhg0N+ER+cO6jMUp/qex37VHj+Fy9zFfXIKG VQtZ/QIAZBsSQoBQzyuARi6fmEy/u7BofB9otWNPWZSgy0+md+pV/I0rrf/PiyNka4To qceg== X-Gm-Message-State: AHQUAuZLtXhVaIHPk0K4t6EMLCak7o+a/Jfx9cEbT+czT0kifghhTkZp HLyxeNB37SBvTttQS7cCj/U= X-Google-Smtp-Source: AHgI3IbdICog+7Nd9HxY0f/OiPU1qr70Mu4hD0Lyd9XXRgvi5jbarbjKyX23A1vx/xFkUJiP6Qv28A== X-Received: by 2002:a62:61c3:: with SMTP id v186mr31074593pfb.55.1550601038994; Tue, 19 Feb 2019 10:30:38 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id a4sm10333021pga.52.2019.02.19.10.30.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 10:30:38 -0800 (PST) Subject: Re: [PATCH bpf-next 1/9] bpf: Add bpf helper bpf_tcp_enter_cwr To: brakmo , netdev Cc: Martin Lau , Alexei Starovoitov References: <20190219053830.2086578-1-brakmo@fb.com> From: Eric Dumazet Message-ID: <67c8aaa3-81a5-b1c2-5be4-938a139f3013@gmail.com> Date: Tue, 19 Feb 2019 10:30:37 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190219053830.2086578-1-brakmo@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/18/2019 09:38 PM, brakmo wrote: > This patch adds a new bpf helper BPF_FUNC_tcp_enter_cwr > "int bpf_tcp_enter_cwr(struct bpf_tcp_sock *tp)". > It is added to BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog > which currently can be attached to the ingress and egress > path. > Do we have the guarantee socket is a tcp one, and that the caller owns the socket lock ? Please describe the exact context for this helper being used.