From: Jijie Shao <shaojijie@huawei.com>
To: Paolo Abeni <pabeni@redhat.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>
Cc: <shaojijie@huawei.com>, <shenjian15@huawei.com>,
<wangjie125@huawei.com>, <liuyonglong@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/7] net: hns3: fix add VLAN fail issue
Date: Thu, 2 Nov 2023 20:29:28 +0800 [thread overview]
Message-ID: <67db0780-59b6-48d2-8d1b-9492c13380e3@huawei.com> (raw)
In-Reply-To: <6603e0480feea2e7a28a865705da52bb99679a35.camel@redhat.com>
on 2023/11/2 18:31, Paolo Abeni wrote:
> On Sat, 2023-10-28 at 10:59 +0800, Jijie Shao wrote:
>
> /* when port base vlan enabled, we use port base vlan as the vlan
> * filter entry. In this case, we don't update vlan filter table
> @@ -10481,7 +10482,9 @@ int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
> * and try to remove it from hw later, to be consistence
> * with stack
> */
> + mutex_lock(&hdev->vport_lock);
> set_bit(vlan_id, vport->vlan_del_fail_bmap);
> + mutex_unlock(&hdev->vport_lock);
> It looks like that the 'hclge_rm_vport_vlan_table()' call a few lines
> above will now happen with the vport_lock unlocked.
>
> That looks racy and would deserve at least a comment explaining why
> it's safe.
>
> Thanks,
>
> Paolo
Yeah, this is a problem that causes the function to be invoked when it
is not locked. We'll get lock before the function be invoked in V2
Thanks, Jijie
next prev parent reply other threads:[~2023-11-02 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 2:59 [PATCH net 0/7] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2023-10-28 2:59 ` [PATCH net 1/7] net: hns3: fix add VLAN fail issue Jijie Shao
2023-11-02 10:31 ` Paolo Abeni
2023-11-02 12:29 ` Jijie Shao [this message]
2023-10-28 2:59 ` [PATCH net 2/7] net: hns3: add barrier in vf mailbox reply process Jijie Shao
2023-10-28 2:59 ` [PATCH net 3/7] net: hns3: fix incorrect capability bit display for copper port Jijie Shao
2023-10-28 2:59 ` [PATCH net 4/7] net: hns3: fix out-of-bounds access may occur when coalesce info is read via debugfs Jijie Shao
2023-10-28 2:59 ` [PATCH net 5/7] net: hns3: fix variable may not initialized problem in hns3_init_mac_addr() Jijie Shao
2023-10-28 2:59 ` [PATCH net 6/7] net: hns3: fix VF reset fail issue Jijie Shao
2023-11-02 10:45 ` Paolo Abeni
2023-11-02 12:16 ` Jijie Shao
2023-11-02 16:24 ` Paolo Abeni
2023-10-28 2:59 ` [PATCH net 7/7] net: hns3: fix VF wrong speed and duplex issue Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67db0780-59b6-48d2-8d1b-9492c13380e3@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox