From: Yotam Gigi <yotamg@mellanox.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Donald Sharp <sharpd@cumulusnetworks.com>
Subject: ipmr: MFC routes when VIF deleted
Date: Sun, 11 Jun 2017 11:55:07 +0300 [thread overview]
Message-ID: <67ef0899-928a-d2cb-bf12-4bea80240dbe@mellanox.com> (raw)
I have been looking into some weird behavior, and I am not sure whether it is
a bug or a feature.
When a VIF with index v gets deleted, the MFC routes does not get updated, which
means that there can be routes pointing to that VIF. On datapath, when packet
hits that route, the VIF validity will be checked and will not be sent to that
device (but still, the route does not get updated). Now, if the user creates
another VIF with the same index v but different underlay device, the same route
will forward the traffic to that device.
It is relevant to mention that when user adds a MFC route, only the active VIFs
are used, so the flow of adding a route with dummy VIF indices and then
connecting those VIF indices to real device is not supported. The only way to
create a MFC route that has non existing VIFs is to create one with existing
VIFs and then delete them.
Do we really want to support that? To me, it looks like a buggy flow and I
suggest that upon VIF deletion, the MFC routes will be updated to not point to
any non existing VIF indices.
next reply other threads:[~2017-06-11 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 8:55 Yotam Gigi [this message]
2017-06-11 16:34 ` ipmr: MFC routes when VIF deleted Nikolay Aleksandrov
2017-06-12 0:58 ` Donald Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ef0899-928a-d2cb-bf12-4bea80240dbe@mellanox.com \
--to=yotamg@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox